Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-4933: Support adding label based indexes to apiserver cache #4934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenchun
Copy link

@chenchun chenchun commented Oct 29, 2024

  • One-line PR description: Support adding label based indexes to apiserver cache
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chenchun
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @chenchun!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @chenchun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

keps/sig-api-machinery/4933-cacher-label-index/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/4933-cacher-label-index/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/4933-cacher-label-index/README.md Outdated Show resolved Hide resolved
Comment on lines +198 to +202
- Improve the efficiency of processing pod events of watch requests in apiserver when running Spark and Flink jobs.
- Improve the processing efficiency of list requests with label selectors by adding label indexes.
- Reduce the CPU usage of apiserver when running Spark and Flink jobs.
- Indirectly improve cluster scheduling performance when cluster load is high when running Spark and Flink jobs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why specifically Spark and Flink?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I have add "The same improvements may apply to any other workloads as well if they also list and watch resources by labels." below to clarify this.

keps/sig-api-machinery/4933-cacher-label-index/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/4933-cacher-label-index/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/4933-cacher-label-index/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/4933-cacher-label-index/README.md Outdated Show resolved Hide resolved
@chenchun chenchun force-pushed the add-label-index branch 2 times, most recently from 1f93720 to a764223 Compare November 1, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants