-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4933: Support adding label based indexes to apiserver cache #4934
base: master
Are you sure you want to change the base?
Conversation
chenchun
commented
Oct 29, 2024
•
edited
Loading
edited
- One-line PR description: Support adding label based indexes to apiserver cache
- Issue link: Support adding label based indexes to apiserver cache #4933
- Other comments:
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chenchun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @chenchun! |
Hi @chenchun. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5442da7
to
4631a86
Compare
- Improve the efficiency of processing pod events of watch requests in apiserver when running Spark and Flink jobs. | ||
- Improve the processing efficiency of list requests with label selectors by adding label indexes. | ||
- Reduce the CPU usage of apiserver when running Spark and Flink jobs. | ||
- Indirectly improve cluster scheduling performance when cluster load is high when running Spark and Flink jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why specifically Spark and Flink?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I have add "The same improvements may apply to any other workloads as well if they also list and watch resources by labels." below to clarify this.
1f93720
to
a764223
Compare
a764223
to
c35b264
Compare