KEP-5073: add Release Signoff Checklist section #5171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
kind/kep
|
/approve @thockin |
aaron-prindle
force-pushed
the
kep-5073-release-signoff-checklist
branch
2 times, most recently
from
6986b77 to
89ca7b8
Compare
|
Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve @deads2k |
aaron-prindle
force-pushed
the
kep-5073-release-signoff-checklist
branch
from
89ca7b8 to
703221a
Compare
k8s-ci-robot
added
size/L
aaron-prindle
force-pushed
the
kep-5073-release-signoff-checklist
branch
from
703221a to
48eb2a8
Compare
6 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaron-prindle, deads2k, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the initial KEP here:
#5074
the "Release Signoff Checklist" section seems to be missing which has caused the KEP to be flagged as missing the enhancements window. (see comment here: #5073 (comment)). I believe we should be able to get this in 1.33 if I can get this PR merged added the section with the appropriate information and getting a sign-off for an Enhancment Exception. Apologies for the inconvience, thanks