Refactor ListSubnets #2804
Merged
Refactor ListSubnets #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
| } | ||
|
|
||
| n, exists, err := z.nodeTopologyInformer.GetIndexer().GetByKey(nodeTopologyCRName) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error getting node topology CR %s from cache: %w", nodeTopologyCRName, err) | ||
| return []nodetopologyv1.SubnetConfig{z.defaultSubnetConfig} |
There was a problem hiding this comment.
Maybe we missed logging the error here
| wantSubnets: defaultSubnet, | ||
| }, | ||
| { | ||
| desc: "node topology crd has synced", |
There was a problem hiding this comment.
nit: typo - "has not synced"
k8s-ci-robot
added
the
needs-rebase
swetharepakula
force-pushed
the
refactor-list-subnets
branch
from
211f517 to
ec6e33a
Compare
k8s-ci-robot
removed
the
needs-rebase
* As part of ZoneGetter initialization, generate the default subnet config to stop re-generating the config in every ListSubnets call * ListSubnets will always return the current list of subnets * TransactionSyncer syncInternalImpl depends on ListSubnets to determine which set of subnets are valid (flag gate occurs in ListSubnet). This abstracts the subnet determination to the zone getter * Add unit tests for ListSubnets
swetharepakula
force-pushed
the
refactor-list-subnets
branch
from
ec6e33a to
1c51d0c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @gauravkghildiyal