Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinder: switch WaitForAllControlPlaneComponents workflow to false #3158

Merged
merged 1 commit into from
Feb 6, 2025
Merged

kinder: switch WaitForAllControlPlaneComponents workflow to false #3158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ols/update-workflows/templates/workflows/wait-for-all-control-plane-components-tasks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# IMPORTANT! this workflow is imported by wait-for-all-control-plane-components* workflows.
version: 1
summary: |
This workflow implements a sequence of tasks used to test kubeadm init and join with the WaitForAllControlPlaneComponents feature gate enabled.
This workflow implements a sequence of tasks used to test kubeadm init and join with the WaitForAllControlPlaneComponents feature gate disabled.
vars:
# vars defines default values for variable used by tasks in this workflow;
# those values might be overridden when importing this files.
Expand Down Expand Up @@ -59,7 +59,7 @@ tasks:
- --copy-certs=auto
- --loglevel=debug
- --kubeadm-verbosity={{ .vars.kubeadmVerbosity }}
- --kubeadm-feature-gate="WaitForAllControlPlaneComponents=true"
- --kubeadm-feature-gate="WaitForAllControlPlaneComponents=false"
timeout: 5m
- name: join
description: |
Expand Down
2 changes: 1 addition & 1 deletion .../ci/tools/update-workflows/templates/workflows/wait-for-all-control-plane-components.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: 1
summary: |
This workflow tests if kubeadm {{ .InitVersion }} can "init" and "join" nodes with the feature gate
WaitForAllControlPlaneComponents feature enabled. The Kubernetes version is at {{ .KubernetesVersion }}.
WaitForAllControlPlaneComponents feature disabled. The Kubernetes version is at {{ .KubernetesVersion }}.
test grid > https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-wait-for-all-control-plane-components-{{ dashVer .KubernetesVersion }}
config > https://git.k8s.io/test-infra/config/jobs/kubernetes/sig-cluster-lifecycle/{{ .TargetFile }}
vars:
Expand Down
2 changes: 1 addition & 1 deletion kinder/ci/workflows/wait-for-all-control-plane-components-latest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
version: 1
summary: |
This workflow tests if kubeadm latest can "init" and "join" nodes with the feature gate
WaitForAllControlPlaneComponents feature enabled. The Kubernetes version is at latest.
WaitForAllControlPlaneComponents feature disabled. The Kubernetes version is at latest.
test grid > https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-wait-for-all-control-plane-components-latest
config > https://git.k8s.io/test-infra/config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-wait-for-all-control-plane-components.yaml
vars:
Expand Down
4 changes: 2 additions & 2 deletions kinder/ci/workflows/wait-for-all-control-plane-components-tasks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# IMPORTANT! this workflow is imported by wait-for-all-control-plane-components* workflows.
version: 1
summary: |
This workflow implements a sequence of tasks used to test kubeadm init and join with the WaitForAllControlPlaneComponents feature gate enabled.
This workflow implements a sequence of tasks used to test kubeadm init and join with the WaitForAllControlPlaneComponents feature gate disabled.
vars:
# vars defines default values for variable used by tasks in this workflow;
# those values might be overridden when importing this files.
Expand Down Expand Up @@ -60,7 +60,7 @@ tasks:
- --copy-certs=auto
- --loglevel=debug
- --kubeadm-verbosity={{ .vars.kubeadmVerbosity }}
- --kubeadm-feature-gate="WaitForAllControlPlaneComponents=true"
- --kubeadm-feature-gate="WaitForAllControlPlaneComponents=false"
timeout: 5m
- name: join
description: |
Expand Down