golangci-lint update and support for Go 1.21

[pohly]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

v1.54.0 is the first release with official support for Go 1.21. go-ruleguard
must be >= 0.3.20 because of
quasilyte/go-ruleguard#449 with Go
1.21. golangci-lint itself doesn't depend on a recent enough release yet, so
this was done manually.

One downside of updating golangci-lint to v1.54.0 without also updating
logcheck is that golangci-lint now complains about logcheck using the old
plugin API:

    ERROR: level=warning msg="plugin: 'AnalyzerPlugin' plugins are deprecated, please use the new plugin signature: https://golangci-lint.run/contributing/new-linters/#create-a-plugin"

Related-to: kubernetes/release#3076

Special notes for your reviewer:

There is an issue with go-critic and ruleguard which needs a workaround in verify-golangci-lint.sh: the Go toolchain used for compiling the linter must not be inside a Go module.

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.28 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.28.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 10:32:39 UTC 2023.

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pohly]

This is WIP because:

• new golangcli-lint has to be released
• logcheck: support settings in golangci-lint kubernetes-sigs/logtools#18 needs to be merged and included in a release deferred to future PR
• templating and inlining support for the logcheck.conf needs to be merged same

[liggitt]

there may be a fix for the go1.21 / go-critic issue to try, see #119037 (comment)

[pohly]

I've tried that fix by bumping the github.com/quasilyte/go-ruleguard dependency and that seems to work.

[liggitt]

In order to bump release branches to go1.21, we'll need to pick any required changes to support go1.21 back. Can this PR be split into the minimal set to run on go1.21, and a follow-up to switch to the new plugin interface to keep the size of the backports as small as possible?

[pohly]

https://github.com/golangci/golangci-lint/pull/4002/files added an env variable for suppressing the warning. This is included in this PR now.

[pohly]

/hold

To prevent merging without additional approval from someone else.

[pohly]

/retest

[liggitt]

/lgtm
/approve
/hold cancel

go ahead and open picks to release-1.25+ branches once this merges so those will be prepped for go1.21 whenever it makes it back to those branches

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: fe6e939c574a952c423a80401bc8f0fc628036a1

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [liggitt,pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

/sig testing

[pohly]

Cherry-picks created.