[Deploy](K8s) addition of Kubernetes manifests #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dipankar Das <[email protected]>
|
Is there anything to add more? |
saiyam1814
reviewed
Sep 16, 2022
| containers: | ||
| - name: kubesimplify-cont | ||
| # TODO: Replace the image with new image | ||
| image: public.ecr.aws/dipankardas011/kubesimplify-website:v2 |
There was a problem hiding this comment.
We need to change this to have kubesimplify and not your personal
There was a problem hiding this comment.
What is the new image to be used?
There was a problem hiding this comment.
We do not have a kubesimplify account , need to think how can we do it and also give access to a few people
There was a problem hiding this comment.
then let this pr be in this state till the registry is ready to be used👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dipankar Das [email protected]
Fixes Issue
Changes proposed
Addition of Kubernetes Resources
Screenshots
Note to reviewers