✨ Enable Patching of WorkStatus #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Duan <[email protected]>
Signed-off-by: Jun Duan <[email protected]>
Signed-off-by: Jun Duan <[email protected]>
|
I hope this could help to unblock kubestellar/kubestellar#1580. |
|
/lgtm |
ezrasilvera
approved these changes
Feb 21, 2024
|
nice work @waltforme, thank you !! |
YW! @pdettori |
| @@ -1,4 +1,4 @@ | |||
| name: test workstatus creation | |||
| name: test workstatus operations | |||
There was a problem hiding this comment.
So I would change the name of this file too.
There was a problem hiding this comment.
Thanks! Did it by #29 .
| @@ -48,7 +48,6 @@ type WorkStatusList struct { | |||
|
|
|||
| // Manifest represents a resource to be deployed | |||
| type RawStatus struct { | |||
| // +kubebuilder:validation:EmbeddedResource | |||
There was a problem hiding this comment.
This seems like an inferior choice for how to solve the problem.
There was a problem hiding this comment.
Would be happy to learn about a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #21.