Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-42021: fix vm list for search page #1964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented May 22, 2024

📝 Description

  • Label filters not working for the list
  • VM list appearance not adequate for the search page (name filter show up on the VM list and should appear only on the top of the search page, the VirtualMachine title should not show up)

🎥 Demo

Before

Screenshot from 2024-05-22 10-01-20

How other resource lists looks like in this page

Screenshot from 2024-05-22 10-01-49

After

Screenshot from 2024-05-22 09-54-58

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 22, 2024

@upalatucci: This pull request references CNV-42021 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

Add a brief description

🎥 Demo

Before

Screenshot from 2024-05-22 10-01-20

How other resource lists looks like in this page

Screenshot from 2024-05-22 10-01-49

After

Screenshot from 2024-05-22 09-54-58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and pcbailey May 22, 2024 08:02
Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 22, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 22, 2024

@upalatucci: This pull request references CNV-42021 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

  • Label filters not working for the list
  • VM list appearance not adequate for the search page

🎥 Demo

Before

Screenshot from 2024-05-22 10-01-20

How other resource lists looks like in this page

Screenshot from 2024-05-22 10-01-49

After

Screenshot from 2024-05-22 09-54-58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 22, 2024

@upalatucci: This pull request references CNV-42021 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

  • Label filters not working for the list
  • VM list appearance not adequate for the search page (name filter show up on the VM list and should appear only on the top of the search page, the VirtualMachine title should not show up)

🎥 Demo

Before

Screenshot from 2024-05-22 10-01-20

How other resource lists looks like in this page

Screenshot from 2024-05-22 10-01-49

After

Screenshot from 2024-05-22 09-54-58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

const [vms, vmLoaded, loadError] = useKubevirtWatchResource<V1VirtualMachine[]>(
{
fieldSelector,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check first with the proxy. Its probably working before merging; u need to run the proxy locally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In searchpage labels filtering is not working for VM list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants