Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Alona, cwilkers, & jobbler from reviewer/approver #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aburdenthehand
Copy link
Contributor

Sadly @AlonaKaplan @cwilkers and @jobbler are no longer active in the project. It has been a bit over 6 months since their last contribution and we should remove them from our reviewer/approver list.

Thank you for your past contributions, and for your help in making this project what it is today.

(Also minor housekeeping: moving jed to alphabetical order)

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 30, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from aburdenthehand. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@jean-edouard jean-edouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @AlonaKaplan @cwilkers @jobbler
Please take a second to LGTM if you see this

@EdDev
Copy link
Member

EdDev commented Oct 10, 2024

@dhiller had a script that does this, it will be cleaner if we use it to do this type of actions.

@aburdenthehand
Copy link
Contributor Author

@EdDev I am okay with a script handling this in the future however to the best of my knowledge the only script we have today targets members in the org after 12 months of inactivity and removes them. I'm not sure if a person removed from the org would affect their being tagged as a reviewer based on these owners files.

@EdDev
Copy link
Member

EdDev commented Oct 14, 2024

@EdDev I am okay with a script handling this in the future however to the best of my knowledge the only script we have today targets members in the org after 12 months of inactivity and removes them. I'm not sure if a person removed from the org would affect their being tagged as a reviewer based on these owners files.

I think it removed them from the org, based on the CNCF policy of inactivity.

If we remove specific members, we need to mention what policy exactly we follow, how we detect these members and what are the steps needed to politely retire them.

But if there is an agreement on all of the details, don't let me be in the way.

@aburdenthehand
Copy link
Contributor Author

This doesn't remove them from the org, just as reviewers and approvers with special privileges. They will presumably be removed after 12 months of inactivity but at the moment they are inactive in the community and being tagged on reviews which limits visibility on issues/prs.
I'm using the same criteria that we apply for project maintainers but I agree that it would be worth being explicit about how we remove inactive reviewers and approvers in the future. Looking through the history of this file it seems as though there is a general agreement that when someone leaves the project they are removed from these roles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants