Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmi controller: Fix UID comparison #39

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Jul 8, 2024

What this PR does / why we need it:
In case claim already exists,
need to compare to the expected UID
which might belong either to the VM or VMI,
depending if the VMI has owner VM or standalone.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

None

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 8, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Jul 8, 2024

/hold

depends on #37

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M labels Jul 8, 2024
In case claim already exists,
need to compare to the expected UID
which might belong either to the VM or VMI,
depending if the VMI has owner VM or standalone.

Signed-off-by: Or Shoval <[email protected]>
@oshoval
Copy link
Collaborator Author

oshoval commented Jul 8, 2024

/hold cancel

rebased

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@qinqon
Copy link
Collaborator

qinqon commented Jul 8, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@qinqon
Copy link
Collaborator

qinqon commented Jul 8, 2024

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@qinqon
Copy link
Collaborator

qinqon commented Jul 8, 2024

/hold cancel
all good

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@kubevirt-bot kubevirt-bot merged commit f53ba76 into kubevirt:main Jul 8, 2024
3 of 4 checks passed
@oshoval
Copy link
Collaborator Author

oshoval commented Jul 8, 2024

Thanks
Will create a tag bit later so it will be consumed by CNAO etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants