-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmi controller: Fix UID comparison #39
Conversation
/hold depends on #37 |
In case claim already exists, need to compare to the expected UID which might belong either to the VM or VMI, depending if the VMI has owner VM or standalone. Signed-off-by: Or Shoval <[email protected]>
/hold cancel rebased |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/hold cancel |
Thanks |
What this PR does / why we need it:
In case claim already exists,
need to compare to the expected UID
which might belong either to the VM or VMI,
depending if the VMI has owner VM or standalone.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: