Exclude record valid range end in uniqueness validation

[wata727]

ActiveRecord::Bitemporal::Uniqueness#scope_relation validates that a record is unique over the valid period of the record being added. For example, if valid_from is 2024-03-01 and valid_datetime is 2024-06-01, the period to be validated will be from 2024-06-01 to 9999-12-31.

                       2024-03-01             2024-06-01                9999-12-31
                            |----------------------|----------------------|
                       valid_from           valid_datetime

                                                   <---------------------->

On the other hand, if the valid_datetime is earlier than the valid_from (e.g. 2024-01-01), the following period is validated:

2024-01-01             2024-03-01             2024-06-01                9999-12-31
                            |---------------------------------------------|
                       valid_from

     <---------------------->

In this case the range is calculated as follows:

activerecord-bitemporal/lib/activerecord-bitemporal/bitemporal.rb

Lines 595 to 602 in 322fa8a

	# レコードを更新する時に valid_datetime が valid_from ~ valid_to の範囲外だった場合、
	# 一番近い未来の履歴レコードを参照して更新する
	# という仕様があるため、それを考慮して valid_to を設定する
	if (record_valid_time && (record.valid_from..record.valid_to).cover?(record_valid_time)) == false && (record.persisted?)
	finder_class.ignore_valid_datetime.where(bitemporal_id: record.bitemporal_id).valid_from_gt(target_datetime).order(valid_from: :asc).first.valid_from
	else
	valid_to
	end

In principle this should be the same as the actual update logic, but it's not an exact match. The corresponding logic is as follows:

activerecord-bitemporal/lib/activerecord-bitemporal/bitemporal.rb

Lines 490 to 492 in 322fa8a

	# 対象基準日において有効なレコード
	# NOTE: 論理削除対象
	current_valid_record = self.class.find_at_time(target_datetime, self.id)&.tap { |record|

activerecord-bitemporal/lib/activerecord-bitemporal/bitemporal.rb

Lines 533 to 536 in 322fa8a

	# 有効なレコードがない場合
	else
	# 一番近い未来にある Instance を取ってきて、その valid_from を valid_to に入れる
	nearest_instance = self.class.where(bitemporal_id: bitemporal_id).valid_from_gt(target_datetime).ignore_valid_datetime.order(valid_from: :asc).first

Since the find_at_time adds the WHERE valid_from <= valid_datetime AND valid_to > valid_datetime, it is correct to use ... rather than .. to see whether valid_datetime is included in the valid period.

Excluding the end of range would change the validated range when the valid_datetime is equal to valid_to, so gt is changed to gteq.

This change has little to no user impact, it's just a refactoring.

[kumaie-shr]

LGTM 🚀

[krororo]

LGTM!