chore: Input, InputWithTooltip, SearchInputの内部ロジックを整理 #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtsushiM
changed the title
AtsushiM
commented
Mar 5, 2025
| } | ||
|
|
||
| return (e: FocusEvent<HTMLInputElement>) => onFocus(e) | ||
| }, [onFocus]) |
There was a problem hiding this comment.
既存の挙動を無駄関数を使って再現しているだけであったため、削除しました
AtsushiM
commented
Mar 5, 2025
| } | ||
|
|
||
| return (e: FocusEvent<HTMLInputElement>) => onBlur(e) | ||
| }, [onBlur]) |
There was a problem hiding this comment.
こちらも同様に無駄な関数だったため削除しています
AtsushiM
commented
Mar 5, 2025
| () => wrapperClassNameGenerator({ disabled, readOnly, className }), | ||
| [disabled, readOnly, className], | ||
| ) | ||
| const wrapperStyle = useMemo(() => { |
There was a problem hiding this comment.
classNameとstyleを同時にmemoする意味が薄いため分割しています
yagimushi
force-pushed
the
fix-format-class-name-generator-4
branch
from
91f8166 to
68659aa
Compare
commit: |
AtsushiM
requested review from
moshisora and
schktjm
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法