chore: Heading/LanguageSwitcher, Icon, InformationPanelの内部ロジックを整理する

packages/smarthr-ui/src/components/Header/LanguageSwitcher/LanguageSwitcher.tsx

@@ -1,6 +1,14 @@
 'use client'
 
-import React, { HTMLAttributes, ReactNode, useCallback, useMemo } from 'react'
+import React, {
+  type FC,
+  type HTMLAttributes,
+  type KeyboardEvent,
+  type MouseEvent,
+  type ReactNode,
+  memo,
+  useMemo,
+} from 'react'
 import { VariantProps, tv } from 'tailwind-variants'
 
 import { type DecoratorsType } from '../../../hooks/useDecorators'
@@ -20,7 +28,7 @@ export type Props = {
   decorators?: DecoratorsType<'triggerLabel' | 'checkIconAlt'>
   /** 言語切替UIで言語を選択した時に発火するコールバック関数 */
   onLanguageSelect?: (code: string) => void
-} & VariantProps<typeof appLauncher>
+} & VariantProps<typeof classNameGenerator>
 
 type ElementProps = Omit<HTMLAttributes<HTMLElement>, keyof Props>
 
@@ -29,7 +37,27 @@ const CHECK_ICON_ALT = '選択中'
 const ARROW_KEY_REGEX = /^Arrow(Up|Down|Left|Right)$/
 const ARROW_UPS_REGEX = /^Arrow(Up|Left)$/
 
-const appLauncher = tv({
+const ON_KEY_DOWN_CONTENT = (e: KeyboardEvent<HTMLDivElement>) => {
+  if (!ARROW_KEY_REGEX.test(e.key)) {
+    return
+  }
+
+  e.preventDefault()
+
+  const buttons = tabbable(e.currentTarget)
+  const i = buttons.indexOf(e.target as HTMLElement)
+  let buttonAt = 0
+
+  if (ARROW_UPS_REGEX.test(e.key)) {
+    buttonAt = i - 1
+  } else if (i + 1 === buttons.length) {
+    buttonAt = i + 1
+  }
+
+  buttons.at(buttonAt)?.focus()
+}
+
+const classNameGenerator = tv({
   slots: {
     switchButton: [
       'shr-border-none shr-font-normal shr-text-white shr-transition-transform shr-duration-100 shr-bg-transparent shr-px-0.25',
@@ -64,7 +92,7 @@ const appLauncher = tv({
   },
 })
 
-export const LanguageSwitcher: React.FC<Props & ElementProps> = ({
+export const LanguageSwitcher: FC<Props & ElementProps> = ({
   narrow,
   enableNew,
   invert = enableNew,
@@ -75,7 +103,13 @@ export const LanguageSwitcher: React.FC<Props & ElementProps> = ({
   onLanguageSelect,
   ...rest
 }) => {
-  const locales = useMemo(() => Object.entries(localeMap), [localeMap])
+  const { locales, defaultCurrentLang } = useMemo(
+    () => ({
+      locales: Object.entries(localeMap),
+      defaultCurrentLang: Object.keys(localeMap)[0],
+    }),
+    [localeMap],
+  )
   const decoratedTexts = useMemo(() => {
     if (!decorators) {
       return {
@@ -89,12 +123,9 @@ export const LanguageSwitcher: React.FC<Props & ElementProps> = ({
       checkIconAlt: decorators.checkIconAlt?.(CHECK_ICON_ALT) || CHECK_ICON_ALT,
     }
   }, [decorators])
-  const currentLang = useMemo(
-    () => locale || defaultLocale || Object.keys(localeMap)[0],
-    [locale, defaultLocale, localeMap],
-  )
-  const styles = useMemo(() => {
-    const { languageButton, languageItemsList, languageItem, switchButton } = appLauncher()
+  const currentLang = locale || defaultLocale || defaultCurrentLang
+  const classNames = useMemo(() => {
+    const { languageButton, languageItemsList, languageItem, switchButton } = classNameGenerator()
 
     return {
       languageButton: languageButton(),
@@ -104,54 +135,34 @@ export const LanguageSwitcher: React.FC<Props & ElementProps> = ({
     }
   }, [enableNew, invert])
 
-  const handleLanguageSelect = useMemo(
+  const onClickLanguageSelect = useMemo(
     () =>
       onLanguageSelect
-        ? (e: React.MouseEvent<HTMLButtonElement>) => {
+        ? (e: MouseEvent<HTMLButtonElement>) => {
             onLanguageSelect(e.currentTarget.value)
           }
         : undefined,
     [onLanguageSelect],
   )
 
-  const handleKeyDown = useCallback((e: React.KeyboardEvent<HTMLDivElement>) => {
-    if (!ARROW_KEY_REGEX.test(e.key)) {
-      return
-    }
-
-    e.preventDefault()
-
-    const buttons = tabbable(e.currentTarget)
-    const i = buttons.indexOf(e.target as HTMLElement)
-    let buttonAt = 0
-
-    if (ARROW_UPS_REGEX.test(e.key)) {
-      buttonAt = i - 1
-    } else if (i + 1 === buttons.length) {
-      buttonAt = i + 1
-    }
-
-    buttons.at(buttonAt)?.focus()
-  }, [])
-
   return (
     <Dropdown {...rest}>
       <MemoizedDropdownTrigger
         narrow={narrow}
         invert={invert}
-        className={styles.switchButton}
+        className={classNames.switchButton}
         label={decoratedTexts.triggerLabel}
       />
-      <DropdownContent onKeyDown={handleKeyDown} role="presentation">
-        <ul className={styles.languageItemsList}>
+      <DropdownContent role="presentation" onKeyDown={ON_KEY_DOWN_CONTENT}>
+        <ul className={classNames.languageItemsList}>
           {locales.map(([code, label]) => (
             <LanguageListItemButton
               key={code}
               code={code}
-              className={styles.languageItem}
-              buttonStyle={styles.languageButton}
+              className={classNames.languageItem}
+              buttonStyle={classNames.languageButton}
               current={currentLang === code}
-              handleLanguageSelect={handleLanguageSelect}
+              onClick={onClickLanguageSelect}
               iconAlt={decoratedTexts.checkIconAlt}
             >
               {label}
@@ -163,19 +174,19 @@ export const LanguageSwitcher: React.FC<Props & ElementProps> = ({
   )
 }
 
-const LanguageListItemButton = React.memo<{
+const LanguageListItemButton = memo<{
   code: string
   children: string
   className: string
   buttonStyle: string
   current: boolean
   iconAlt: ReactNode
-  handleLanguageSelect?: (e: React.MouseEvent<HTMLButtonElement>) => void
-}>(({ code, children, buttonStyle, className, current, iconAlt, handleLanguageSelect }) => (
+  onClick?: (e: MouseEvent<HTMLButtonElement>) => void
+}>(({ code, children, buttonStyle, className, current, iconAlt, onClick }) => (
   <li key={code} className={className} aria-current={current} lang={code}>
     <Button
       value={code}
-      onClick={handleLanguageSelect}
+      onClick={onClick}
       wide
       prefix={current ? <FaCheckIcon color="MAIN" alt={iconAlt} /> : null}
       className={buttonStyle}
@@ -185,7 +196,7 @@ const LanguageListItemButton = React.memo<{
   </li>
 ))
 
-const MemoizedDropdownTrigger = React.memo<
+const MemoizedDropdownTrigger = memo<
   Pick<Props, 'narrow' | 'invert'> & { className: string; label: ReactNode }
 >(({ narrow, invert, className, label }) => (
   <DropdownTrigger>

packages/smarthr-ui/src/components/Icon/generateIcon.tsx

@@ -1,13 +1,14 @@
-import React, { ComponentProps, useMemo } from 'react'
-import { IconType } from 'react-icons'
+import React, { type ComponentProps, type ReactNode, memo, useMemo } from 'react'
 import { tv } from 'tailwind-variants'
 
 import { colors, fontSize, textColor } from '../../themes'
-import { FontSizes } from '../../themes/createFontSize'
-import { AbstractSize, CharRelativeSize } from '../../themes/createSpacing'
-import { Gap } from '../../types'
 import { VisuallyHiddenText } from '../VisuallyHiddenText'
 
+import type { FontSizes } from '../../themes/createFontSize'
+import type { AbstractSize, CharRelativeSize } from '../../themes/createSpacing'
+import type { Gap } from '../../types'
+import type { IconType } from 'react-icons'
+
 /**
  * literal union type に補完を効かせるためのハック
  * https://github.com/microsoft/TypeScript/issues/29729
@@ -55,21 +56,21 @@ type ElementProps = Omit<ComponentProps<'svg'>, keyof IconProps>
 
 type BaseComponentProps = {
   /**アイコンの説明テキスト*/
-  alt?: React.ReactNode
+  alt?: ReactNode
   /** アイコンと並べるテキスト */
-  text?: React.ReactNode
+  text?: ReactNode
   /** アイコンと並べるテキストとの溝 */
   iconGap?: CharRelativeSize | AbstractSize
   /** `true` のとき、アイコンを右側に表示する */
   right?: boolean
 }
 export type Props = Omit<IconProps & ElementProps, keyof BaseComponentProps> & BaseComponentProps
 
-const icon = tv({
+const iconClassNameGenerator = tv({
   base: 'smarthr-ui-Icon group-[]/iconWrapper:shr-shrink-0 group-[]/iconWrapper:shr-translate-y-[0.125em] forced-colors:shr-fill-[CanvasText]',
 })
 
-const wrapper = tv({
+const wrapperClassNameGenerator = tv({
   base: ['smarthr-ui-Icon-withText shr-group/iconWrapper shr-inline-flex shr-items-baseline'],
   variants: {
     gap: {
@@ -112,7 +113,7 @@ const wrapper = tv({
 })
 
 export const generateIcon = (SvgIcon: IconType) => {
-  const Icon = React.memo<Props>(
+  const Icon = memo<Props>(
     ({
       color,
       className,
@@ -140,8 +141,8 @@ export const generateIcon = (SvgIcon: IconType) => {
         return undefined
       }, [ariaHidden, alt, ariaLabel, ariaLabelledby])
 
-      const iconStyle = useMemo(() => icon({ className }), [className])
-      const wrapperStyle = useMemo(() => wrapper({ gap: iconGap }), [iconGap])
+      const iconClassName = useMemo(() => iconClassNameGenerator({ className }), [className])
+      const wrapperClassName = useMemo(() => wrapperClassNameGenerator({ gap: iconGap }), [iconGap])
 
       const replacedColor = useMemo(() => {
         if (color && existsColor(color)) {
@@ -169,7 +170,7 @@ export const generateIcon = (SvgIcon: IconType) => {
           width={iconSize}
           height={iconSize}
           color={replacedColor}
-          className={iconStyle}
+          className={iconClassName}
           role={role}
           aria-hidden={actualAriaHidden}
           aria-label={ariaLabel}
@@ -181,7 +182,7 @@ export const generateIcon = (SvgIcon: IconType) => {
 
       if (text) {
         return (
-          <span className={wrapperStyle}>
+          <span className={wrapperClassName}>
             {right && text}
             {visuallyHiddenAlt}
             {svgIcon}