Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store user preferences in local storage #3413

Closed
2 tasks
schogges opened this issue Jan 17, 2025 · 0 comments · Fixed by #3457
Closed
2 tasks

Store user preferences in local storage #3413

schogges opened this issue Jan 17, 2025 · 0 comments · Fixed by #3457
Assignees
@schogges
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.10.x

Comments

@schogges
Copy link
Contributor

schogges commented Jan 17, 2025 •
edited
Loading

Description

This is a follow-up to #3283 and #3408

A user might have some preferences for the GUI that we should consider and store. An example can be how many entries the listings should show or how the config should be displayed. We can set defaults like 50 entries in listings or always use a structured view instead of the yaml representation.
When storing and retrieving the user preferences we should consider that the URL always has priority over what is stored as a preference (i.e. open a url foo/bar?size=15 should render 15 entries even though the user preference is size: 75).

  • store and retrieve user preference of size in listings
  • store and retrieve user preference of format
@schogges schogges added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Jan 17, 2025
@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 20, 2025
@schogges schogges mentioned this issue Jan 23, 2025
Merged
@schogges schogges added this to the 2.10.x milestone Jan 24, 2025
@schogges schogges self-assigned this Jan 24, 2025
schogges added a commit that referenced this issue Jan 30, 2025
@schogges @johncowen
feat: store global user preferences size and format (#3457)
40bf55a 
Stores user preferences for `size` of listings and `format` of configs
globally in `localStorage`. Usually we store preferences like column
sizes on a route basis. To store preferences "globally" we use the `/`
route (still including the prefix).

Closes #3413

---------

Signed-off-by: schogges <[email protected]>
Signed-off-by: John Cowen <[email protected]>
Co-authored-by: John Cowen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schogges schogges

Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.10.x
Development

Successfully merging a pull request may close this issue.

feat: store global user preferences size and format schogges/kuma-gui
2 participants
@lukidzi @schogges