-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store global user preferences size and format #3457
feat: store global user preferences size and format #3457
Conversation
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/kuma-gui/src/app/application/components/data-collection/DataCollection.vue
Outdated
Show resolved
Hide resolved
@johncowen I think this is good to go for now, but there is still an issue I want to resolve separately. Storing the preferences works, but when trying to retrieve them there is still an issue. It looks like the |
Ok thanks for the heads-up! Lemme take a look! |
This will be using the cache, if you add a Maybe we should pair on this as I'm not sure I understand the issue enough to replicate. Lemme finish looking over this and I'll give you a ping. Initial look from me tho, I think it looks great! |
packages/kuma-gui/src/app/application/components/route-view/RouteView.vue
Outdated
Show resolved
Hide resolved
packages/kuma-gui/src/app/application/components/route-view/RouteView.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
7b74034
to
478afd0
Compare
Signed-off-by: John Cowen <[email protected]>
packages/kuma-gui/src/app/application/components/route-view/RouteView.vue
Outdated
Show resolved
Hide resolved
packages/kuma-gui/src/app/application/components/route-view/RouteView.vue
Show resolved
Hide resolved
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johncowen I think this is good to go in now? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep LGTM!
Stores user preferences for
size
of listings andformat
of configs globally inlocalStorage
. Usually we store preferences like column sizes on a route basis. To store preferences "globally" we use the/
route (still including the prefix).Closes #3413