Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store global user preferences size and format #3457

Merged
merged 22 commits into from
Jan 30, 2025

Conversation

schogges
Copy link
Contributor

@schogges schogges commented Jan 23, 2025

Stores user preferences for size of listings and format of configs globally in localStorage. Usually we store preferences like column sizes on a route basis. To store preferences "globally" we use the / route (still including the prefix).

Closes #3413

@schogges schogges requested a review from a team as a code owner January 23, 2025 15:18
@schogges schogges requested review from johncowen and removed request for a team January 23, 2025 15:18
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit f6933eb
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/679ba443c1eef4000886f4c5
😎 Deploy Preview https://deploy-preview-3457--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@schogges schogges added this to the 2.10.x milestone Jan 24, 2025
@schogges schogges self-assigned this Jan 24, 2025
@schogges schogges removed this from the 2.10.x milestone Jan 24, 2025
@schogges schogges removed their assignment Jan 24, 2025
@schogges
Copy link
Contributor Author

@johncowen I think this is good to go for now, but there is still an issue I want to resolve separately. Storing the preferences works, but when trying to retrieve them there is still an issue. It looks like the meResponse in the watcher is not updated properly and even a manual refresh doesn't seem to help. Lmk 🙂

@johncowen
Copy link
Contributor

Ok thanks for the heads-up! Lemme take a look!

@johncowen
Copy link
Contributor

It looks like the meResponse in the watcher is not updated properly and even a manual refresh doesn't seem to help.

This will be using the cache, if you add a CacheControl: no-cache (do a search in the codebase for that and you'll see how), this might resolve this issue (maybe).

Maybe we should pair on this as I'm not sure I understand the issue enough to replicate. Lemme finish looking over this and I'll give you a ping.

Initial look from me tho, I think it looks great!

Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
Signed-off-by: schogges <[email protected]>
@schogges schogges force-pushed the feat/store_global_user_preferences branch from 7b74034 to 478afd0 Compare January 27, 2025 12:23
Copy link
Contributor Author

@schogges schogges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johncowen I think this is good to go in now? 🙂

Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep LGTM!

@schogges schogges merged commit 40bf55a into kumahq:master Jan 30, 2025
17 checks passed
@schogges schogges deleted the feat/store_global_user_preferences branch January 30, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store user preferences in local storage
2 participants