Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): mistakenly setting 'kuma.io/display-name' as label (backport of #10430) #11948

Closed
wants to merge 1 commit into from

Conversation

kumahq[bot]
Copy link
Contributor

@kumahq kumahq bot commented Oct 30, 2024

Automatic cherry-pick of #10430 for branch release-2.7

Generated by action

cherry-picked commit da824ce
⚠️ ⚠️ ⚠️ Conflicts happened when cherry-picking! ⚠️ ⚠️ ⚠️

On branch release-2.7
Your branch is up to date with 'origin/release-2.7'.

You are currently cherry-picking commit da824ce57.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pkg/plugins/resources/k8s/store.go
	both modified:   pkg/plugins/runtime/k8s/webhooks/defaulter.go
	both modified:   pkg/plugins/runtime/k8s/webhooks/defaulter_test.go

no changes added to commit (use "git add" and/or "git commit -a")

)

fix(kuma-cp): mistakenly setting 'kuma.io/display-name' as label while it should an annotation due to the length limit

Signed-off-by: Ilya Lobkov <[email protected]>
@kumahq kumahq bot requested a review from a team as a code owner October 30, 2024 17:46
@kumahq kumahq bot requested review from jijiechen and Icarus9913 and removed request for a team October 30, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants