Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): add priorityClassName to Helm Chart #12652

Merged
merged 5 commits into from
Feb 3, 2025
Merged

feat(kuma-cp): add priorityClassName to Helm Chart #12652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f4e0c9
feat(kuma-cp): add priorityClassName to Helm Chart
jmromanos Jan 23, 2025
fe1ff92
feat(egress): add priorityClassName to Helm Chart
jmromanos Feb 3, 2025
0735963
feat(ingress): add priorityClassName to Helm Chart
jmromanos Feb 3, 2025
bcde77f
Merge branch 'master' into master
lukidzi Feb 3, 2025
51d3c55
Merge branch 'master' into master
lukidzi Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.dump-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ controlPlane:
# This is rendered as a template, so you can use variables to generate match labels.
topologySpreadConstraints:

# -- Priority Class Name of the Kuma Control Plane
priorityClassName: ""

# -- Failure policy of the mutating webhook implemented by the Kuma Injector component
injectorFailurePolicy: Fail

Expand Down Expand Up @@ -532,6 +535,9 @@ ingress:
# This is rendered as a template, so you can use variables to generate match labels.
topologySpreadConstraints:

# -- Priority Class Name of the ingress
priorityClassName: ""

# -- Security context at the pod level for ingress
podSecurityContext:
runAsNonRoot: true
Expand Down Expand Up @@ -655,6 +661,9 @@ egress:
# This is rendered as a template, so you can use variables to generate match labels.
topologySpreadConstraints:

# -- Priority Class Name of the egress
priorityClassName: ""

# -- Security context at the pod level for egress
podSecurityContext:
runAsNonRoot: true
Expand Down
3 changes: 3 additions & 0 deletions deployments/charts/kuma/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ A Helm chart for the Kuma Control Plane
| controlPlane.podDisruptionBudget.maxUnavailable | int | `1` | The maximum number of unavailable pods allowed by the budget |
| controlPlane.affinity | object | `{"podAntiAffinity":{"preferredDuringSchedulingIgnoredDuringExecution":[{"podAffinityTerm":{"labelSelector":{"matchExpressions":[{"key":"app.kubernetes.io/name","operator":"In","values":["{{ include \"kuma.name\" . }}"]},{"key":"app.kubernetes.io/instance","operator":"In","values":["{{ .Release.Name }}"]},{"key":"app","operator":"In","values":["{{ include \"kuma.name\" . }}-control-plane"]}]},"topologyKey":"kubernetes.io/hostname"},"weight":100}]}}` | Affinity placement rule for the Kuma Control Plane pods. This is rendered as a template, so you can reference other helm variables or includes. |
| controlPlane.topologySpreadConstraints | string | `nil` | Topology spread constraints rule for the Kuma Control Plane pods. This is rendered as a template, so you can use variables to generate match labels. |
| controlPlane.priorityClassName | string | `""` | Priority Class Name of the Kuma Control Plane |
| controlPlane.injectorFailurePolicy | string | `"Fail"` | Failure policy of the mutating webhook implemented by the Kuma Injector component |
| controlPlane.service.apiServer.http.nodePort | int | `30681` | Port on which Http api server Service is exposed on Node for service of type NodePort |
| controlPlane.service.apiServer.https.nodePort | int | `30682` | Port on which Https api server Service is exposed on Node for service of type NodePort |
Expand Down Expand Up @@ -157,6 +158,7 @@ A Helm chart for the Kuma Control Plane
| ingress.podDisruptionBudget.maxUnavailable | int | `1` | The maximum number of unavailable pods allowed by the budget |
| ingress.affinity | object | `{"podAntiAffinity":{"preferredDuringSchedulingIgnoredDuringExecution":[{"podAffinityTerm":{"labelSelector":{"matchExpressions":[{"key":"app.kubernetes.io/name","operator":"In","values":["{{ include \"kuma.name\" . }}"]},{"key":"app.kubernetes.io/instance","operator":"In","values":["{{ .Release.Name }}"]},{"key":"app","operator":"In","values":["kuma-ingress"]}]},"topologyKey":"kubernetes.io/hostname"},"weight":100}]}}` | Affinity placement rule for the Kuma Ingress pods This is rendered as a template, so you can reference other helm variables or includes. |
| ingress.topologySpreadConstraints | string | `nil` | Topology spread constraints rule for the Kuma Mesh Ingress pods. This is rendered as a template, so you can use variables to generate match labels. |
| ingress.priorityClassName | string | `""` | Priority Class Name of the ingress |
| ingress.podSecurityContext | object | `{"runAsGroup":5678,"runAsNonRoot":true,"runAsUser":5678}` | Security context at the pod level for ingress |
| ingress.containerSecurityContext | object | `{"readOnlyRootFilesystem":true}` | Security context at the container level for ingress |
| ingress.serviceAccountAnnotations | object | `{}` | Annotations to add for Control Plane's Service Account |
Expand Down Expand Up @@ -194,6 +196,7 @@ A Helm chart for the Kuma Control Plane
| egress.podDisruptionBudget.maxUnavailable | int | `1` | The maximum number of unavailable pods allowed by the budget |
| egress.affinity | object | `{"podAntiAffinity":{"preferredDuringSchedulingIgnoredDuringExecution":[{"podAffinityTerm":{"labelSelector":{"matchExpressions":[{"key":"app.kubernetes.io/name","operator":"In","values":["{{ include \"kuma.name\" . }}"]},{"key":"app.kubernetes.io/instance","operator":"In","values":["{{ .Release.Name }}"]},{"key":"app","operator":"In","values":["kuma-egress"]}]},"topologyKey":"kubernetes.io/hostname"},"weight":100}]}}` | Affinity placement rule for the Kuma Egress pods. This is rendered as a template, so you can reference other helm variables or includes. |
| egress.topologySpreadConstraints | string | `nil` | Topology spread constraints rule for the Kuma Egress pods. This is rendered as a template, so you can use variables to generate match labels. |
| egress.priorityClassName | string | `""` | Priority Class Name of the egress |
| egress.podSecurityContext | object | `{"runAsGroup":5678,"runAsNonRoot":true,"runAsUser":5678}` | Security context at the pod level for egress |
| egress.containerSecurityContext | object | `{"readOnlyRootFilesystem":true}` | Security context at the container level for egress |
| egress.serviceAccountAnnotations | object | `{}` | Annotations to add for Control Plane's Service Account |
Expand Down
3 changes: 3 additions & 0 deletions deployments/charts/kuma/templates/cp-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ spec:
{{- with .Values.controlPlane.topologySpreadConstraints }}
topologySpreadConstraints: {{ tpl (toYaml . | nindent 8) $ }}
{{- end }}
{{- with .Values.controlPlane.priorityClassName }}
lukidzi marked this conversation as resolved.
Show resolved Hide resolved
priorityClassName: {{ . }}
{{- end }}
securityContext:
{{- toYaml .Values.controlPlane.podSecurityContext | trim | nindent 8 }}
serviceAccountName: {{ include "kuma.name" . }}-control-plane
Expand Down
3 changes: 3 additions & 0 deletions deployments/charts/kuma/templates/egress-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ spec:
{{- with .Values.egress.topologySpreadConstraints }}
topologySpreadConstraints: {{ tpl (toYaml . | nindent 8) $ }}
{{- end }}
{{- with .Values.egress.priorityClassName }}
priorityClassName: {{ . }}
{{- end }}
securityContext:
{{- toYaml .Values.egress.podSecurityContext | trim | nindent 8 }}
serviceAccountName: {{ include "kuma.name" . }}-egress
Expand Down
3 changes: 3 additions & 0 deletions deployments/charts/kuma/templates/ingress-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ spec:
{{- with .Values.ingress.topologySpreadConstraints }}
topologySpreadConstraints: {{ tpl (toYaml . | nindent 8) $ }}
{{- end }}
{{- with .Values.ingress.priorityClassName }}
priorityClassName: {{ . }}
{{- end }}
securityContext:
{{- toYaml .Values.ingress.podSecurityContext | trim | nindent 8 }}
serviceAccountName: {{ include "kuma.name" . }}-ingress
Expand Down
9 changes: 9 additions & 0 deletions deployments/charts/kuma/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ controlPlane:
# This is rendered as a template, so you can use variables to generate match labels.
topologySpreadConstraints:

# -- Priority Class Name of the Kuma Control Plane
priorityClassName: ""

# -- Failure policy of the mutating webhook implemented by the Kuma Injector component
injectorFailurePolicy: Fail

Expand Down Expand Up @@ -532,6 +535,9 @@ ingress:
# This is rendered as a template, so you can use variables to generate match labels.
topologySpreadConstraints:

# -- Priority Class Name of the ingress
priorityClassName: ""

# -- Security context at the pod level for ingress
podSecurityContext:
runAsNonRoot: true
Expand Down Expand Up @@ -655,6 +661,9 @@ egress:
# This is rendered as a template, so you can use variables to generate match labels.
topologySpreadConstraints:

# -- Priority Class Name of the egress
priorityClassName: ""

# -- Security context at the pod level for egress
podSecurityContext:
runAsNonRoot: true
Expand Down
9 changes: 9 additions & 0 deletions docs/generated/raw/helm-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ controlPlane:
# This is rendered as a template, so you can use variables to generate match labels.
topologySpreadConstraints:

# -- Priority Class Name of the Kuma Control Plane
priorityClassName: ""

# -- Failure policy of the mutating webhook implemented by the Kuma Injector component
injectorFailurePolicy: Fail

Expand Down Expand Up @@ -532,6 +535,9 @@ ingress:
# This is rendered as a template, so you can use variables to generate match labels.
topologySpreadConstraints:

# -- Priority Class Name of the ingress
priorityClassName: ""

# -- Security context at the pod level for ingress
podSecurityContext:
runAsNonRoot: true
Expand Down Expand Up @@ -655,6 +661,9 @@ egress:
# This is rendered as a template, so you can use variables to generate match labels.
topologySpreadConstraints:

# -- Priority Class Name of the egress
priorityClassName: ""

# -- Security context at the pod level for egress
podSecurityContext:
runAsNonRoot: true
Expand Down
Loading