Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): deprecate MeshSubset kind in top level targetRef #12660

Merged
merged 2 commits into from
Jan 28, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(kuma-cp): deprecate MeshSubset kind in top level targetRef
Fix: #12362
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Automaat committed Jan 24, 2025
commit 52b0b6c88816f8185af9c53f776021a65951187b
5 changes: 5 additions & 0 deletions pkg/plugins/policies/core/jsonpatch/validators/validator.go
Original file line number Diff line number Diff line change
@@ -128,5 +128,10 @@ func TopLevelTargetRefDeprecations(targetRef *common_api.TargetRef) []string {
fmt.Sprintf("%s value for 'targetRef.kind' is deprecated, use %s with '%s' tag instead", common_api.MeshService, common_api.MeshSubset, mesh_proto.ServiceTag),
}
}
if targetRef.Kind == common_api.MeshSubset {
return []string{
fmt.Sprintf("%s value for 'targetRef.kind' is deprecated, use %s with labels instead", common_api.MeshSubset, common_api.Dataplane),
}
}
return nil
}