Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace errors.Errorf by fmt.Errorf #8388

Closed
wants to merge 3 commits into from
Closed

replace errors.Errorf by fmt.Errorf #8388

wants to merge 3 commits into from

Conversation

mmorel-35
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree we should part from github.com/pkg/errors I think the presence of the stacktrace in these errors is nice and we should think more methodically about a replacement: pkg/errors#245

I've opened: #8390 to think a little more about this. I think it may be useful to open a MADR to decide when we should have stacktraces and when we shouldn't

@mmorel-35 mmorel-35 marked this pull request as ready for review November 16, 2023 09:58
@mmorel-35 mmorel-35 requested a review from a team as a code owner November 16, 2023 09:58
@mmorel-35 mmorel-35 requested review from slonka and bartsmykla and removed request for a team November 16, 2023 09:58
@jakubdyszkiewicz
Copy link
Contributor

Triage: Thanks for the contrib, but we decided to stay with pkg/errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants