-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAB_RESULT_CM transform #32
Conversation
…N_SOURCE switch in CTL creation
@@ -415,66 +415,6 @@ begin | |||
end; | |||
/ | |||
|
|||
BEGIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dckc, yes, it seemed like it was best to create/populate the PMN_LabNormal table from a .csv rather than doing a bunch of inserts with hard-coded strings. As I recall, the motivation was that Mike needed access to those values earlier in the process.
We hoped this change would be something that SCILHS would merge back to their version.
@@ -1335,7 +1275,8 @@ m.start_date SPECIMEN_DATE, | |||
to_char(m.start_date,'HH:MI') SPECIMEN_TIME, | |||
m.end_date RESULT_DATE, | |||
to_char(m.end_date,'HH:MI') RESULT_TIME, | |||
CASE WHEN m.ValType_Cd='T' THEN NVL(nullif(m.TVal_Char,''),'NI') ELSE 'NI' END RESULT_QUAL, -- TODO: Should be a standardized value | |||
--CASE WHEN m.ValType_Cd='T' THEN NVL(nullif(m.TVal_Char,''),'NI') ELSE 'NI' END RESULT_QUAL, -- TODO: Should be a standardized value | |||
'NI' RESULT_QUAL, -- Temporary fix for KUMC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mprittie: Do you have a design in mind that will allow you to revert this temporary fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@njgraham: The TODO on the original line indicated that they knew that this was an issue. After talking with Dan, he suggested this temporary fix and logging a bug with the SCHILS folks (which I did ARCH-commons#19). Jeff responded on Thursday, but it sounds like they haven't found the right solution yet.
The pcornet_lab synonym isn't created before pcornet_mapping.sql is run.
See commit comments for details.