Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Game] Drum kit added #4896

Merged
merged 6 commits into from
Jul 24, 2024
Merged

[New Game] Drum kit added #4896

merged 6 commits into from
Jul 24, 2024

Conversation

shellygarg10
Copy link
Contributor

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #4876


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • [] I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 18, 2024

Thank you @shellygarg10 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 21, 2024
@shellygarg10
Copy link
Contributor Author

shellygarg10 commented Jul 23, 2024

hi @kunjgit @ishita-43 Is there anything else I need to do before it can be merged? Also in issue it is labelled as level 3 here it is labelled as level 2 !

@ishita-43 ishita-43 added level3 Adding new features and removed level2 Enhancement in gssoc labels Jul 23, 2024
@ishita-43
Copy link
Collaborator

hi @kunjgit @ishita-43 Is there anything else I need to do before it can be merged? Also in issue it is labelled as level 3 here it is labelled as level 2 !

You need to resolve the arising merge conflicts in readme.md file

@shellygarg10
Copy link
Contributor Author

@ishita-43 I resolved the arising merge conflicts in readme.md file. I hope there is no issue anymore

@ishita-43
Copy link
Collaborator

@ishita-43 I resolved the arising merge conflicts in readme.md file. I hope there is no issue anymore

Pr will soon be merged by the admin

@kunjgit kunjgit merged commit b1112ce into kunjgit:main Jul 24, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 24, 2024

Thank you @shellygarg10 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@kunjgit kunjgit mentioned this pull request Aug 2, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Drum kit
3 participants