Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Added all the Games and Games load now #4904

Merged
merged 21 commits into from
Jul 22, 2024
Merged

[Enhancement]: Added all the Games and Games load now #4904

merged 21 commits into from
Jul 22, 2024

Conversation

mohitgedar
Copy link
Contributor

PR Description 📜

Fixes #4903

Summary of the Changes that I have made :

  • I have added nearly 200-250 games to the gamesData.json file , that were added to the project but were not added to the website yet , hence enhancing the project overall
  • I have updated contributors guideline to add a section so that contributors can add their games to the website on their own , the section includes , what to add to gamesData.json and how to add the game in different scenarios such as index.html is in main folder or subfolder or main html files is index.html or with some other name.
  • I have updated contributors guideline to highlight and explain the problems that contributors are facing and creating unknowingly in naming convention and adding files based on my experience during adding all these games to gamesData.json. such as adding preview images to wrong folder , providing names for the preview images that don't match the game or not providing the name for their main folder in prescribed format
  • I Have added Preview Images for those games that did not had any in assets/images folder buy opening those and taking a ScreenShot of the game and then renaming them to match the game name and also crop them to be a perfect preview of the game
  • I Have removed some images , not all ,that were Redundant and were not preview images, such as asset images of mario-game and some other
  • I Have updated names of many images to refer to the actual games , some were refering to other games and some did not had the same name as the game
  • I have also changed the names of many main-html files that were named differently and was not loading properly because of using different name conventions .
  • I have updated index.js so that all the games gets shown automatically without manually having to provide the no. of games that are added to the gamesData.json, hence from now on whenever a new game is added to gamesData.json it will be rendered automatically on the main website.
  • I have removed "color matcher " file from games folder as it is not used for anything and is a redundant file , added unnecessarily , to make the project more maintainable, it don't belong to any game also and the game that it may have belonged to don't need it , game is working fine .
  • I have Deleted "Mario Matching Game" because it is a duplicate game with same name "mario_matching_game" and same code , must have been added by mistake.

Note:- Pagination for games is not working anymore but that is not because of the changes that I have made .

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have specified the respective issue number for which I am creating this PR
  • I have added preview for the website before and after the changes via YouTube links
  • There are not conflicts with the main project.

Preview Using YouTube 📸

Before changes
After changes


Thank you soo much for contributing to our repository 💗

mohitgedar added 21 commits July 19, 2024 20:05
@mohitgedar
Added upto 479 games
de0e0ec 
here i have added games to the gameData.json so that they are shown on the main website , at present nearly 200 to 250 games are still not visible on the website , I am working to add them , along with adding required images that are not uploaded , deleting unnecessary images , renaming some to match game name , and removing those that are added to the wrong folders
@mohitgedar
removed the images from wrong folder
f202cf4 
these images were added to games folder instead of the dedicated game folder of  a particular game , so I removed them , since the actual game already have them
@mohitgedar
Name change of the game
6476768 
There was a spelling mistake in the game name so I Have corrected the game name from buliding to building
@mohitgedar
moved image to right folder
a1ee2e2 
here I have moved the preview image of Drawing_app game from its main folder to the dedicated folder assets/images
@mohitgedar
update html file name to make game work
e7eeba1 
here I have Updated the name of the game from carrom.html to index.html so that the game actually runs when clicked on the main website instead of showing the folders
@mohitgedar
updated index.js to show all games from gameData.json
cd918d4 
before  changes we had  to manually enter the number of games that need to be shown from gameData.json , anytime we add a new game we had to update that index number , now it is being done automatically , all the games present in the json file will be shown
@mohitgedar
name update to match game name
6a692c9 
these images refer to one game but the name of another game got used , so I updated the image name so that they refer to the particular game they belong to
@mohitgedar
image name update to remove .png from the name
073783d 
here the contributor added the .png extension in the name itself , causing bugs for game load , so the name is updated to removed the problem
@mohitgedar
game image name updated to refer to game
6426321 
here the image don't have the same name as game , causing confusion for adding new games when similar name games are added , so the name of the image is updated to match the name of the game i.e Dice_Showdown_Game
@mohitgedar
name update of Dsa_quiz_game images
7976bb1 
here also the names of the image don't match the game so updated the name to match the game name, also removed unnecessary image as we only need one ,hence reduced the load time of the website
@mohitgedar
added images for games
d58ccab 
some games were added to the project without any preview image , so I am adding the images for the games,
@mohitgedar
Updated Contributors Guideline
9f5a98d 
Here I have updated contributors guideline based on my experience when I was adding games to the gameData.json , I came through a lot of cases where the name of preview image is not same as game , format is added in the name itself , images are added in the wrong folders , instead of just one preview image too many have been added , increasing the load   time of the website , some people even made the main html file with some other name , other than index.html , increasing overhead to add that game , some even put the index.html in subfolders. some added the preview image to the game folder itself and not in assets/images
@mohitgedar
update main html file name
0a2b871 
Here I updated the name of main html file to index.html so it can be loaded to main website automatically
@mohitgedar
Deleted Mario Matching Game
392176f 
I have deleted this game because there is a exact copy of this same game with same name ,same code ,i.e. Mario_Matching
@mohitgedar
updated file name from index1.html to index.html
2ebe469 
updated game main html file name so that it load automatically without extra manual additions
@mohitgedar
Deleted asset images of Mario-game
08eb026 
These images belong to assets folder of the games , these are not preview images , they are added in the wrong folder
@mohitgedar
Removed color matcher
988c442 
this file is directly added to the games folder, and it have no use there , so to clean up the project overall , I have removed this file
@mohitgedar
Added Preview images
fc12f1f 
I have Added preview Images for the Games that didn't had any
@mohitgedar
updated image names
800d73c 
Some of these images have their names updated to match the game name and some have been removed as they were named using the name of a different game
@mohitgedar
Updated Contributors Guideline to add games to gamesData.json
8eda096 
I have updated contributors guideline , so that contributors themselves add their games to the gameData.json
@mohitgedar
changes to resolve conflicts in gamesData.json
f611fa6 
Changes to resolve conflicts in gamesData.json
@kunjgit
Copy link
Owner

kunjgit commented Jul 19, 2024

Thank you @mohitgedar ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

ishita-43
ishita-43 approved these changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 21, 2024
@kunjgit kunjgit merged commit 52cea9a into kunjgit:main Jul 22, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented Jul 22, 2024

Thank you @mohitgedar , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Games are Not loading And Not all Games are added
3 participants
@mohitgedar @kunjgit @ishita-43