Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PULL_REQUEST_TEMPLATE.md, CONTRIBUTING.md and CONTRIBUTING_GUIDELINE.md #4926

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

mohitgedar
Copy link
Contributor

@mohitgedar mohitgedar commented Jul 22, 2024

PR Description 📜

Fixes #4925

  • I have updated PULL_REQUEST_TEMPLATE.md to add one more point that contributor has added the Game to gamesData.json and it loads on the website properly
  • I have updated CONTRIBUTING.md and CONTRIBUTING_GUIDELINE.md so that the content of both of them match as they both are refering the same thing , also updated some parts to make thing clear as well as updated Pull Request Process to add the points of adding game to gamesData.json so that contributors can know in advance what steps need to be followed , overall enhancing user / contributors experience.

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have specified the respective issue number for which I have requested the new game.

Thank you soo much for contributing to our repository 💗

I Have updated CONTRIBUTING.md and CONTRIBUTING_GUIDELINE.md to match them , also updated Pull Request Process to match the new guidelines
I have updated PULL_REQUEST_TEMPLATE.md to so add one more point that the contributor has added the game to gamesData.json , also updated previous points to make things clear
@kunjgit
Copy link
Owner

kunjgit commented Jul 22, 2024

Thank you @mohitgedar ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ishita-43 ishita-43 added level1 Documentation and small bug fixes in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 23, 2024
@kunjgit kunjgit merged commit 19a274d into kunjgit:main Jul 24, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented Jul 24, 2024

Thank you @mohitgedar , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Contributors guideline needs some update
3 participants