Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a game smash monty mole, contributing under GSSOC'24 #5053

Merged
merged 8 commits into from
Aug 4, 2024
Merged

Adding a game smash monty mole, contributing under GSSOC'24 #5053

merged 8 commits into from
Aug 4, 2024

Conversation

rugved0102
Copy link
Contributor

@rugved0102 rugved0102 commented Jul 31, 2024 •
edited
Loading

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in GameZone's README.md
  • I have added README.md in my Game folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.
  • I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Add your screenshots(Optional) 📸

image


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 31, 2024

Thank you @rugved0102 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ishita-43
Copy link
Collaborator

What is your issue number?

ishita-43
ishita-43 requested changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your game entry into readme. Md file of the gamezone repo
Add your game image into the assets folder of the gamezone

@rugved0102
Update README.md
96cf388 
added smash-monty-mole game name in readme.md
@rugved0102
Add files via upload
574ad51 
added smash-monty-mole game screenshot
@rugved0102
Copy link
Contributor Author

Done with the requested changes. Any suggested modification ??
I am contributing under gssoc'24 so I request you to label it

ishita-43
ishita-43 requested changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make following changes

README.md Outdated
@@ -1678,6 +1678,7 @@ This repository also provides one such platforms where contributers come over an
|[Garden-Builder-game](https://github.com/kunjgit/GameZone/tree/main/Games/Garden-Builder-game)|

| [Airhockey_game](https://github.com/kunjgit/GameZone/tree/main/Games/Airhockey_game)|
|[Smash-Monty-Mole]()|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your link also would be same as other only add your game folder name in the end

@ishita-43 ishita-43 added level3 Adding new features gssoc GSSoC24 program label labels Aug 2, 2024
@rugved0102
Copy link
Contributor Author

done !

ishita-43
ishita-43 approved these changes Aug 3, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kunjgit kunjgit merged commit 557add4 into kunjgit:main Aug 4, 2024
@kunjgit
Copy link
Owner

kunjgit commented Aug 4, 2024

Thank you @rugved0102 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@kunjgit kunjgit mentioned this pull request Aug 10, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rugved0102 @kunjgit @ishita-43