-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autofocus modifier fix #973
Conversation
✔️ Deploy Preview for heuristic-goodall-67c4b1 ready! 🔨 Explore the source changes: bacbe12 🔍 Inspect the deploy log: https://app.netlify.com/sites/heuristic-goodall-67c4b1/deploys/617ab415adc2e20008e24c47 😎 Browse the preview: https://deploy-preview-973--heuristic-goodall-67c4b1.netlify.app/ |
Hi Pierre, thanks for your contribution, I will review this ASAP |
Linting job failed because you probably have some Prettier or other automatic linter adding trailing commas not complying to our eslint rules, please fix your settings (or just run |
I added a prettier rule to Mind if I commit the prettier rule update? |
Oh, actually no, we don't mind... It's a good thing to update it since we don't keep track of Prettier anymore (we uninstalled it and just use ESLint --fix as a prettifier) |
Prettier v1.9 is needed to lint for |
My advice is to deactivate Prettier for the workspace and just fix the lint errors. |
Hope this fixed the formatting.🤞 |
Closing this as it is old now. Feel free to reopen if feature is this fix is needed |
What does this PR do ?
This PR implement suggestions in issue #972, ignoring meta keys in the search field auto focus feature.
How should this be manually tested?
cmd + c
or corresponding copy-paste key for your OS and make sure the search field isn't auto focusedc
without any meta modifier keys to make sure the search field is auto focusedOther changes
The PR also updates the policy
JSON
-value example to reflect expected array value for therestrictedTo
property (in theCreate Profile
-screen).