Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofocus modifier fix #973

Closed

Conversation

pierreminik
Copy link

What does this PR do ?

This PR implement suggestions in issue #972, ignoring meta keys in the search field auto focus feature.

How should this be manually tested?

  • Step 1 : In the data tab go into an index and collection
  • Step 2 : Press cmd + c or corresponding copy-paste key for your OS and make sure the search field isn't auto focused
  • Step 3 : Press c without any meta modifier keys to make sure the search field is auto focused

Other changes

The PR also updates the policy JSON-value example to reflect expected array value for the restrictedTo property (in the Create Profile-screen).

@netlify
Copy link

netlify bot commented Oct 21, 2021

✔️ Deploy Preview for heuristic-goodall-67c4b1 ready!

🔨 Explore the source changes: bacbe12

🔍 Inspect the deploy log: https://app.netlify.com/sites/heuristic-goodall-67c4b1/deploys/617ab415adc2e20008e24c47

😎 Browse the preview: https://deploy-preview-973--heuristic-goodall-67c4b1.netlify.app/

@xbill82
Copy link
Contributor

xbill82 commented Oct 22, 2021

Hi Pierre, thanks for your contribution, I will review this ASAP

@xbill82
Copy link
Contributor

xbill82 commented Oct 28, 2021

Linting job failed because you probably have some Prettier or other automatic linter adding trailing commas not complying to our eslint rules, please fix your settings (or just run eslint --fix on the files)

@pierreminik
Copy link
Author

pierreminik commented Oct 28, 2021

eslint —fix didn’t it solve it.

I added a prettier rule to trailingComma: “none” which fixes the commas but I gotta find the one that fixes the parentheses around single arguments in arrow functions.

Mind if I commit the prettier rule update?

@xbill82
Copy link
Contributor

xbill82 commented Oct 28, 2021

Oh, actually no, we don't mind... It's a good thing to update it since we don't keep track of Prettier anymore (we uninstalled it and just use ESLint --fix as a prettifier)

@pierreminik
Copy link
Author

Prettier v1.9 is needed to lint for x => x. 😔

@xbill82
Copy link
Contributor

xbill82 commented Oct 28, 2021

My advice is to deactivate Prettier for the workspace and just fix the lint errors.

@pierreminik
Copy link
Author

Hope this fixed the formatting.🤞

@rolljee
Copy link
Contributor

rolljee commented May 14, 2023

Closing this as it is old now. Feel free to reopen if feature is this fix is needed

@rolljee rolljee closed this May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants