types: remove useless _id property for upsert requests

kuzzleio · Dec 4, 2024 · 1d6d203 · 1d6d203
1 parent 48d034c
commit 1d6d203
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 15 deletions.
diff --git a/doc/2/controllers/assets/upsert/index.md b/doc/2/controllers/assets/upsert/index.md
@@ -15,8 +15,8 @@ The Upsert operation allows you to create a new asset or update an existing one
 ### HTTP
 
 ```http
-URL: http://kuzzle:7512/_/device-manager/:engineId/assets/:_id
-Method: POST
+URL: http://kuzzle:7512/_/device-manager/:engineId/assets
+Method: PUT
 ```
 
 ## Other protocols

diff --git a/doc/2/controllers/devices/upsert/index.md b/doc/2/controllers/devices/upsert/index.md
@@ -15,8 +15,8 @@ The Upsert operation allows you to create a new device or update an existing one
 ### HTTP
 
 ```http
-URL: http://kuzzle:7512/_/device-manager/:engineId/devices/:_id
-Method: POST
+URL: http://kuzzle:7512/_/device-manager/:engineId/devices
+Method: PUT
 ```
 
 ## Other protocols

diff --git a/lib/modules/asset/AssetsController.ts b/lib/modules/asset/AssetsController.ts
@@ -62,9 +62,7 @@ export class AssetsController {
         },
         upsert: {
           handler: this.upsert.bind(this),
-          http: [
-            { path: "device-manager/:engineId/assets/:_id", verb: "post" },
-          ],
+          http: [{ path: "device-manager/:engineId/assets", verb: "put" }],
         },
         delete: {
           handler: this.delete.bind(this),

diff --git a/lib/modules/asset/types/AssetApi.ts b/lib/modules/asset/types/AssetApi.ts
@@ -67,9 +67,6 @@ export type ApiAssetMetadataReplaceResult = KDocument<AssetContent>;
 export interface ApiAssetUpsertRequest extends AssetsControllerRequest {
   action: "upsert";
 
-  // TODO it's unused in action, maybe should remove it
-  _id?: string;
-
   refresh?: string;
 
   body: {

diff --git a/lib/modules/device/DevicesController.ts b/lib/modules/device/DevicesController.ts
@@ -64,9 +64,7 @@ export class DevicesController {
         },
         upsert: {
           handler: this.upsert.bind(this),
-          http: [
-            { path: "device-manager/:engineId/devices/:_id", verb: "post" },
-          ],
+          http: [{ path: "device-manager/:engineId/devices", verb: "put" }],
         },
         replaceMetadata: {
           handler: this.replaceMetadata.bind(this),

diff --git a/lib/modules/device/types/DeviceApi.ts b/lib/modules/device/types/DeviceApi.ts
@@ -49,8 +49,6 @@ export type ApiDeviceMetadataReplaceResult = KDocument<DeviceContent>;
 export interface ApiDeviceUpsertRequest extends DevicesControllerRequest {
   action: "upsert";
 
-  _id: string;
-
   refresh?: string;
 
   body: {