fix: getAsset should search in commons assets too #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-mauran
force-pushed
the
KZLPRD-657-fix-create-asset-group-commons
branch
from
012a055 to
8340e8d
Compare
thomas-mauran
changed the title
thomas-mauran
force-pushed
the
KZLPRD-657-fix-create-asset-group-commons
branch
from
bd4e554 to
c6eb1e8
Compare
thomas-mauran
force-pushed
the
KZLPRD-657-fix-create-asset-group-commons
branch
from
6b95020 to
7724630
Compare
Juiced66
approved these changes
Nov 18, 2024
sebtiz13
approved these changes
Nov 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
## [2.4.4](v2.4.3...v2.4.4) (2024-11-18) ### Bug Fixes * getAsset should search in commons assets too ([#380](#380)) ([d588a93](d588a93))
sebtiz13
added a commit
that referenced
this pull request
Nov 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
# [2.5.0](v2.4.4...v2.5.0) (2024-12-05) ### Bug Fixes * **assetservice:** can't replace metadata if not present in asset ([#384](#384)) ([eb65c0a](eb65c0a)) * backport fix ([#380](#380)) ([5392b56](5392b56)) ### Features * add editor hint support ([#386](#386)) ([a9b62df](a9b62df)) * **measure:** allow measures to be pushed on Assets via API (no devices) ([#344](#344)) ([c1073c1](c1073c1)) * **softTenants:** add softTenant ids to assets measures documents ([#383](#383)) ([1b36fe0](1b36fe0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The bug appears when someone tries to create an asset with a model which uses an engineGroup sets to commons, resulting in an error in the frontend saying "insufficient permissions".
The problem comes from the assetCreate in KDM which calls the models:asset:get to get the model of the asset we want to create, the thing is that we don't check if in the engineId: commons, so when this is the case it result in an error being thrown saying the asset we are looking for doesn't exist
How should this be manually tested?