Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kzlprd 724 etq utilisateur jvp cr er des rapport type par soft tenants et par groupes #388

Conversation

cyrng
Copy link
Contributor

@cyrng cyrng commented Jan 8, 2025

What does this PR do ?

It adds optional type in AssetGroup for asset group dashboard template feature

How should this be manually tested?

  • Step 1 : include KDM in the iot-platform
  • Step 2 : create an asset group for example with this payload
  {
  "controller": "device-manager/assetsGroup",
  "action": "create",
  "engineId": "tenant-sdef-sdef",
  "body": {
    "children": [],
    "name": "test groupe 3",
    "parent": null,
    "type": "Batiment"
  }
}
  • Step 3 : update an asset
  • Step 4 : test without type

Other changes

Boyscout

@cyrng cyrng self-assigned this Jan 8, 2025
@cyrng cyrng changed the base branch from master to 2-dev January 8, 2025 11:05
@cyrng cyrng requested review from afondard and EnzoViry1 January 8, 2025 11:06
@EnzoViry1
Copy link
Contributor

LGTM

lib/modules/asset/AssetsGroupsController.ts Outdated Show resolved Hide resolved
@cyrng cyrng merged commit b39e221 into 2-dev Jan 8, 2025
5 checks passed
@cyrng cyrng deleted the KZLPRD-724-ETQ-utilisateur-JVP-cr-er-des-rapport-type-par-soft-tenants-et-par-groupes branch January 8, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants