fix(measure): add mutex to asset update to prevent race condition #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juiced66
approved these changes
Jan 9, 2025
Olive3034
approved these changes
Jan 9, 2025
fmauNeko
approved these changes
Jan 9, 2025
afondard
approved these changes
Jan 9, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
## [2.5.1](v2.5.0...v2.5.1) (2025-01-09) ### Bug Fixes * **measure:** add mutex to asset update to prevent race condition ([#389](#389)) ([53371f4](53371f4))
rolljee
added a commit
that referenced
this pull request
Jan 22, 2025
* fix(measure): add mutex to asset update to prevent race condition (#389) * chore(release): 2.5.1 [skip ci] ## [2.5.1](v2.5.0...v2.5.1) (2025-01-09) ### Bug Fixes * **measure:** add mutex to asset update to prevent race condition ([#389](#389)) ([53371f4](53371f4)) * docs: add since badges to ingestMeasure(s) method (#390) Co-authored-by: rolljee <[email protected]> * feat: update deps (#393) * chore: update deps * chore(release): 2.6.0-dev.1 [skip ci] ## [2.6.0-dev.1](v2.5.1...v2.6.0-dev.1) (2025-01-22) ### Features * update deps ([#393](#393)) ([1b9b936](1b9b936)) * fix: typo in packages/package.json * chore(release): 2.6.0-dev.2 [skip ci] ## [2.6.0-dev.2](v2.6.0-dev.1...v2.6.0-dev.2) (2025-01-22) ### Features * trigger release ([9c82581](9c82581)) ### Bug Fixes * conflict between ([adf8d0f](adf8d0f)) * typo in packages/package.json ([9b6c495](9b6c495)) --------- Co-authored-by: Sébastien Rodriguez <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Juiced66 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Just add mutex lock to asset document update in measures ingest to try to fix a conflict on update due to race condition.
This race condition could be arrived if 2 different devices are linked to the same asset and get processed at the same time.