Support conditions with alternative calendar #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 368 370 +2
===========================================
Files 433 433
Lines 1504 1510 +6
===========================================
+ Hits 1504 1510 +6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
kylekatarnls
force-pushed
the
fix/issue-84-support-alt-calendar-with-conditions
branch
from
818e6ec
to
7f6eddf
Compare
kylekatarnls
force-pushed
the
fix/issue-84-support-alt-calendar-with-conditions
branch
from
7f6eddf
to
327c031
Compare
|
I'm curious, what's the blocker blocking this since 2021? |
|
I have to rebase, IIRC, some tests were failing which means the implementation broke some other features. |
kylekatarnls
force-pushed
the
fix/issue-84-support-alt-calendar-with-conditions
branch
from
327c031
to
7417615
Compare
kylekatarnls
deleted the
fix/issue-84-support-alt-calendar-with-conditions
branch
|
I see we still have a bunch of things here to consider the feature complete: #84 (comment) But it's not stopping from having this partial support merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #84