Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the --kubeconfig frag persistent #2229

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Make the --kubeconfig frag persistent #2229

merged 2 commits into from
Oct 21, 2024

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Oct 21, 2024

Description

Changes proposed in this pull request:

  • make --kubeconfig flag persistent for the whole alpha group
  • prepare code for a new configmap fetching mechanism described in the ticket below

Related issue(s)

@pPrecel pPrecel added area/cli Related to all activities around CLI kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 21, 2024
@pPrecel pPrecel requested a review from a team as a code owner October 21, 2024 12:10
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2024
@anoipm anoipm self-assigned this Oct 21, 2024
@pPrecel pPrecel enabled auto-merge (squash) October 21, 2024 13:22
anoipm
anoipm reviewed Oct 21, 2024
View reviewed changes
internal/cmd/alpha/add/add.go Outdated Show resolved Hide resolved
internal/cmd/alpha/add/add.go Outdated Show resolved Hide resolved
internal/cmd/alpha/add/managed/managed.go Outdated Show resolved Hide resolved
internal/cmd/alpha/add/managed/managed.go Outdated Show resolved Hide resolved
@pPrecel pPrecel merged commit fc4fd73 into kyma-project:main Oct 21, 2024
3 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoipm anoipm anoipm approved these changes

Assignees

@anoipm anoipm

Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pPrecel @anoipm @kyma-bot