Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(AwsVpcPeering): switch to alpine image #45

Merged
merged 1 commit into from
Oct 23, 2024
Merged

test(AwsVpcPeering): switch to alpine image #45

merged 1 commit into from
Oct 23, 2024

Conversation

vandjelk
Copy link
Collaborator

Description

Changes proposed in this pull request:

  • Switch to alpine image as it has netcat built in
  • removes metadata name from resources as they are being injected from declaration
  • updated IP address

@vandjelk vandjelk requested a review from abalaie October 23, 2024 16:59
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2024
abalaie
abalaie approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@abalaie abalaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 23, 2024
@vandjelk vandjelk merged commit c2f7ef2 into kyma-project:main Oct 23, 2024
1 check passed
@vandjelk vandjelk deleted the awsvpcpeering-alpine branch October 23, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalaie abalaie abalaie approved these changes

Assignees

@abalaie abalaie

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vandjelk @abalaie @kyma-bot