KIM Integration - Testing networking for non-default parameters #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaroslaw-pieszka
added
kind/enhancement
|
Add one of following labels |
kyma-bot
added
the
size/M
| instance, operation := fixInstanceAndOperation(broker.AWSPlanID, "eu-west-2", "platform-region") | ||
| operation.ProvisioningParameters.Parameters.Networking = &internal.NetworkingDTO{ | ||
| NodesCidr: "192.168.48.0/20", | ||
| PodsCidr: ptr.String("192.168.48.0/20"), |
There was a problem hiding this comment.
you have the same values for pods and nodes, I think we should have 3 different ranges
There was a problem hiding this comment.
My bad. Fix in the next commit.
piotrmiskiewicz
approved these changes
Aug 7, 2024
|
/lgtm |
jaroslaw-pieszka
deleted the
testing-networking-for-non-default-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#791
#905