-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KIM Integration - Testing networking for non-default parameters #1000
KIM Integration - Testing networking for non-default parameters #1000
Conversation
Add one of following labels |
instance, operation := fixInstanceAndOperation(broker.AWSPlanID, "eu-west-2", "platform-region") | ||
operation.ProvisioningParameters.Parameters.Networking = &internal.NetworkingDTO{ | ||
NodesCidr: "192.168.48.0/20", | ||
PodsCidr: ptr.String("192.168.48.0/20"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have the same values for pods and nodes, I think we should have 3 different ranges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Fix in the next commit.
/lgtm |
Description
Changes proposed in this pull request:
Related issue(s)
#791
#905