Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - Volume support and worker group name #1026

Merged
merged 1 commit into from
Aug 12, 2024
Merged

KIM Integration - Volume support and worker group name #1026

merged 1 commit into from
Aug 12, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Aug 9, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • support for volume size, volume type default values
  • support of worker group name (hard-wired)
  • volume size populated from parameters (if present)

Related issue(s)

#791
#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner August 9, 2024 13:25
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Aug 9, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@jaroslaw-pieszka jaroslaw-pieszka added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed cla: yes Indicates the PR's author has signed the CLA. labels Aug 9, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 9, 2024
@jaroslaw-pieszka jaroslaw-pieszka force-pushed the volume-supported-for-kim branch 3 times, most recently from f31e709 to 7d75fda Compare August 9, 2024 14:03
@jaroslaw-pieszka
setting for all except sap-converged-cloud
fbb17fb 
setting worker name and volume size and type

volume size from parameters

test updated
@szwedm szwedm assigned szwedm and unassigned szwedm Aug 12, 2024
@szwedm szwedm self-requested a review August 12, 2024 07:35
szwedm
szwedm reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding consts for all repeating values? I would like to know more about the origin of values, let's have a short call.

@jaroslaw-pieszka
Copy link
Contributor Author

What do you think about adding consts for all repeating values? I would like to know more about the origin of values, let's have a short call.

It is supposed to be next step in the refactoring. We are working on test in small increments, still a lot to cover and improve.

szwedm
szwedm approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 12, 2024
@kyma-bot kyma-bot merged commit baa06de into kyma-project:main Aug 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @szwedm @kyma-bot