Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - correctly skipped steps for KIM only driven plans #1033

Merged
merged 9 commits into from
Aug 13, 2024
Merged

KIM Integration - correctly skipped steps for KIM only driven plans #1033

merged 9 commits into from
Aug 13, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Aug 13, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • CreateRuntimeWithoutKyma step skipped for KIM only driven plans
  • CheckRuntimeResource called for KIM driven plans

Related issue(s)

#791
#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner August 13, 2024 12:10
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Aug 13, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 13, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed cla: yes Indicates the PR's author has signed the CLA. labels Aug 13, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Aug 13, 2024
@jaroslaw-pieszka jaroslaw-pieszka changed the title KIM Integration - correct skipped steps for KIM only driven plans KIM Integration - correctly skipped steps for KIM only driven plans Aug 13, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 13, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 13, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 13, 2024
@kyma-bot kyma-bot merged commit ba96707 into kyma-project:main Aug 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrmiskiewicz piotrmiskiewicz piotrmiskiewicz approved these changes

Assignees

@piotrmiskiewicz piotrmiskiewicz

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @piotrmiskiewicz @kyma-bot