Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - adjustments to current KIM behavior #1049

Merged
merged 1 commit into from
Aug 19, 2024
Merged

KIM Integration - adjustments to current KIM behavior #1049

merged 1 commit into from
Aug 19, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Aug 19, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Always set label indicating who is driving the provisioning - just use boolean values, "kyma-project.io/controlled-by-provisioner": "false" means KIM (inframan) is controlling the process
  • Set networking.type temporary as "calico" to pass the validation of Runtime CR, and to progress further

Related issue(s)

#791
#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner August 19, 2024 10:25
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Aug 19, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 19, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Aug 19, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 19, 2024
@jaroslaw-pieszka jaroslaw-pieszka force-pushed the always-setting-controlled-by-provisioner-label branch from 6b7620a to 98e2404 Compare August 19, 2024 11:49
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 19, 2024
@kyma-bot kyma-bot merged commit f8e1464 into kyma-project:main Aug 19, 2024
25 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the always-setting-controlled-by-provisioner-label branch August 20, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekMichali MarekMichali MarekMichali approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@MarekMichali MarekMichali

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @MarekMichali @kyma-bot