KIM Integration - instances on runtimes endpoint decorated with Runtime CR
#1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaroslaw-pieszka
added
do-not-merge/work-in-progress
kyma-bot
added
size/S
|
Add one of following labels |
kyma-bot
added
size/L
jaroslaw-pieszka
force-pushed
the
runtime-resource-returned-from-runtimes-endpoint
branch
from
0b65178
to
bf91abe
Compare
kyma-bot
added
size/XL
jaroslaw-pieszka
force-pushed
the
runtime-resource-returned-from-runtimes-endpoint
branch
from
f997c61
to
63235fe
Compare
jaroslaw-pieszka
removed
the
do-not-merge/work-in-progress
internal/runtime/handler.go
Outdated
| Namespace: runtimeNamespaceName, | ||
| Name: runtimeResourceName, | ||
| }, runtimeResourceObject) | ||
| if err != nil { |
There was a problem hiding this comment.
I think in case of "Not Found" error we will have a problem here.
There was a problem hiding this comment.
If there is no runtime resource, let's do not throw any error, just leave the field empty.
There was a problem hiding this comment.
We log Warning and return empty result.
There was a problem hiding this comment.
handle NotFoundError -> log.Info, other error log as warn
There was a problem hiding this comment.
In the next commit/push.
internal/runtime/handler.go
Outdated
| if err != nil { | ||
| h.logger.Warn(fmt.Sprintf("unable to set optional attributes: %s", err.Error())) | ||
| httputil.WriteErrorResponse(w, http.StatusInternalServerError, err) | ||
| return | ||
| } | ||
|
|
||
| if runtimeResourceConfig && dto.RuntimeID != "" && instanceDrivenByKimOnly { |
There was a problem hiding this comment.
I think the instanceDrivenByKimOnly in not necessary here, I'd like to have a possibility to use kcp cli to get the runtime even if it is driven by Provisioner (in the phase when Provisioner is called and runtime resource is created).
There was a problem hiding this comment.
In the next commit/push.
jaroslaw-pieszka
force-pushed
the
runtime-resource-returned-from-runtimes-endpoint
branch
2 times, most recently
from
4eb008f
to
1c82851
Compare
pass necessary data to handler barebones kim config moved to broker package change package reference change package reference again redo reredo removing unused functions fixes to fixes initial stubs for handler tests simplified tests setup handling errors from provisioner (in a nasty way) dto extended and set if RuntimeResource fetched fake client extended, remarks and todos added before test implementation suite corrected no scheme used and make fix run let focus on one test case failing new test cases first passing test case (out of new ones) test cases added error handling for nested fields fix for signature setting workers in the fixture additional assertion review remark and conflict resolved log level depending on k8s client error
jaroslaw-pieszka
force-pushed
the
runtime-resource-returned-from-runtimes-endpoint
branch
from
9c02283
to
8d52691
Compare
piotrmiskiewicz
previously approved these changes
Aug 30, 2024
piotrmiskiewicz
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KEB endpoint
runtimesis used bykcpCLI e.g. to get gardener configuration information (using--gardener-configswitch), and this information is used quite often to assert in SKR tests. Getting gardener configuration requires communication with provisioner, so in case of KIM driven instances is pointless.We need the way to base assertions on the spec fields of Runtime CR.
Changes proposed in this pull request:
runtime-config--gardener-configflag we process instance not known to provisionerRelated issue(s)
#791
#905