Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binding SKR test for response codes #1369

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Add binding SKR test for response codes #1369

merged 6 commits into from
Oct 21, 2024

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Oct 21, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Check HTTP response codes

Related issue(s)

See #1352

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Oct 21, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2024
@MarekMichali
Copy link
Contributor Author

/kind enhancement

@kyma-bot kyma-bot added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 21, 2024
@MarekMichali MarekMichali marked this pull request as ready for review October 21, 2024 12:21
@MarekMichali MarekMichali requested a review from a team as a code owner October 21, 2024 12:21
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 21, 2024 12:21
@MarekMichali MarekMichali added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature labels Oct 21, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit f27310b into kyma-project:main Oct 21, 2024
52 of 54 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarekMichali @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot