Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create e2e provisioning API test #1371

Merged
merged 27 commits into from
Oct 28, 2024
Merged

Create e2e provisioning API test #1371

merged 27 commits into from
Oct 28, 2024

Conversation

KsaweryZietara
Copy link
Contributor

@KsaweryZietara KsaweryZietara commented Oct 21, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • create end-to-end test for checking if Cloud Management Service Provisioning API works as expected.

Related issue(s)
See also #1341

@KsaweryZietara KsaweryZietara added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 21, 2024
@KsaweryZietara KsaweryZietara self-assigned this Oct 21, 2024
@KsaweryZietara KsaweryZietara requested a review from a team as a code owner October 21, 2024 14:09
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 21, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 21, 2024 14:09
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 21, 2024
@KsaweryZietara KsaweryZietara mentioned this pull request Oct 21, 2024
Closed
4 tasks
@KsaweryZietara KsaweryZietara added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 23, 2024
@KsaweryZietara KsaweryZietara requested a review from a team as a code owner October 24, 2024 06:23
@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 24, 2024
@KsaweryZietara KsaweryZietara added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 24, 2024
IwonaLanger
IwonaLanger reviewed Oct 24, 2024
View reviewed changes
docs/contributor/05-10-e2e_tests.md Outdated Show resolved Hide resolved
docs/contributor/05-10-e2e_tests.md Outdated Show resolved Hide resolved
docs/contributor/05-10-e2e_tests.md Outdated Show resolved Hide resolved
docs/contributor/05-10-e2e_tests.md Outdated
@@ -142,13 +146,16 @@ The test executes the following steps:
The test executes the following steps:

1. Provisions a Kyma runtime cluster.
2. Creates a binding using Kubernetes TokenRequest and saves the returned kubeconfig.
2. Creates a SKR binding and saves the returned kubeconfig.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Creates a SKR binding and saves the returned kubeconfig.
2. Creates an SKR binding and saves the returned kubeconfig.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is an SKR binding the same as Kyma Binding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's the same. Will it be more readable when I change all occurrences of SKR binding to Kyma Binding?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, definitely :)

docs/contributor/05-10-e2e_tests.md Outdated Show resolved Hide resolved
docs/contributor/05-10-e2e_tests.md Outdated Show resolved Hide resolved
docs/contributor/05-10-e2e_tests.md Outdated
6. Initializes a Kubernetes client with the returned kubeconfig.
7. Tries to fetch a Secret using the binding from Gardener.
8. Deprovisions the Kyma runtime instance and cleans up the resources.
4. Fetches a Secret using the SKR binding.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any Secret or one specific Secret?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sap-btp-manager secret. Should I change it to: Fetches the sap-btp-manager secret using the Kyma Binding?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please :)

docs/contributor/05-10-e2e_tests.md Outdated
4. Fetches a Secret using the SKR binding.
5. Fetches created SKR binding.
6. Deletes created SKR binding.
7. Tries to fetch Secret using the deleted SKR binding.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a Secret/the Secret?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sap-btp-manager secret. Should I change it to: Tries to fetch the sap-btp-manager secret using the deleted Kyma Binding?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please :)

docs/contributor/05-10-e2e_tests.md Outdated Show resolved Hide resolved
docs/contributor/05-10-e2e_tests.md Outdated Show resolved Hide resolved
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 24, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 25, 2024
KsaweryZietara and others added 22 commits October 25, 2024 08:57
@KsaweryZietara
Rename folder
b154226
@KsaweryZietara
Update docs
e3fe7a1
@KsaweryZietara
Rename test
f8baad1
@KsaweryZietara
Change require no error to assertion
44c5ad1
@KsaweryZietara
Update end-2-end tests docs
b270c75
@KsaweryZietara
Extract paths to functions
8c192a5
@KsaweryZietara
Update docs
29a2fa3
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
ab5f240 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
2770e82 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
2f10f6d 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
285f05e 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
5111dcc 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
022564c 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
a5ef1ef 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
59db15c 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
63528fe 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
9ca37a3 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
31e58ec 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
0e3ca40 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara @IwonaLanger
Update docs/contributor/05-10-e2e_tests.md
130ddef 
Co-authored-by: Iwona Langer <[email protected]>
@KsaweryZietara
Update docs
603fa3d
@KsaweryZietara
Update docs
de669b6
@KsaweryZietara KsaweryZietara removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 25, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit 9244517 into kyma-project:main Oct 28, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

@IwonaLanger IwonaLanger IwonaLanger approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@KsaweryZietara KsaweryZietara

@IwonaLanger IwonaLanger

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KsaweryZietara @jaroslaw-pieszka @IwonaLanger @kyma-bot @kyma-gopher-bot