Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swagger with bindings #1376

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Oct 23, 2024

Description

Changes proposed in this pull request:

  • Update PUT, GET, DELETE for bindings

Related issue(s)

See #1196

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Oct 23, 2024
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2024
@MarekMichali
Copy link
Contributor Author

/kind enhancement

@kyma-bot kyma-bot added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 24, 2024
@MarekMichali MarekMichali marked this pull request as ready for review October 24, 2024 06:39
@MarekMichali MarekMichali requested a review from a team as a code owner October 24, 2024 06:39
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 24, 2024 06:39
content:
application/json:
schema:
$ref: '#/components/schemas/Error'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure if we should use the generic Error or create an appropriate error message for each code. For now I decided to use the generic Error as we have the same approach in the Instances section.

@kyma-gopher-bot kyma-gopher-bot merged commit f218ac0 into kyma-project:main Oct 24, 2024
49 of 57 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants