Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Service Binding Cleanup job #1385

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Improve Service Binding Cleanup job #1385

merged 3 commits into from
Oct 24, 2024

Conversation

szwedm
Copy link
Contributor

@szwedm szwedm commented Oct 24, 2024

Description

Continuation of #1365

Changes proposed in this pull request:

  • handle 410s while performing cleanup,
  • limit query to required data for the cleanup,
  • add unit tests.

Related issue(s)

See #1347

@szwedm szwedm added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 24, 2024
@szwedm szwedm self-assigned this Oct 24, 2024
@szwedm szwedm requested a review from a team as a code owner October 24, 2024 17:48
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Oct 24, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 24, 2024 17:48
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 24, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit d8d8bca into kyma-project:main Oct 24, 2024
34 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szwedm @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot