Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KEB chart #1399

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix KEB chart #1399

merged 1 commit into from
Oct 31, 2024

Conversation

MarekMichali
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fix nesting in values.yaml
  • Fix wrong letter case in template
  • Add missing value to values.yaml

Related issue(s)

@MarekMichali MarekMichali requested a review from a team as a code owner October 31, 2024 07:00
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Oct 31, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 31, 2024 07:00
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2024
@MarekMichali
Copy link
Contributor Author

/kind bug

@kyma-bot kyma-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 31, 2024
@MarekMichali
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 31, 2024
@MarekMichali
Copy link
Contributor Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit d35dec6 into kyma-project:main Oct 31, 2024
26 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarekMichali @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot