Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KymaResourceName and KymaResourceNamespace - KIM integration - phase 1 #931

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Jul 12, 2024

Description

Changes proposed in this pull request:

  • Handling data from KymaTemplate
  • Security configuration

Related issue(s)

#905

#791

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner July 12, 2024 09:27
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Jul 12, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 12, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed cla: yes Indicates the PR's author has signed the CLA. labels Jul 12, 2024
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 12, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 12, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 12, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

logging KymaTemplate length

fixture with kymaTemplate
channel: stable
modules: []
`
preOperation.KymaResourceNamespace = "kyma-system"
err := memoryStorage.Operations().InsertOperation(preOperation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure that kyma template has proper name/namespace? let's discuss it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed, needs redesign. Probably in separate PR.

@jaroslaw-pieszka jaroslaw-pieszka added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@jaroslaw-pieszka
Copy link
Contributor Author

Redesign required.

@jaroslaw-pieszka jaroslaw-pieszka deleted the creating-actual-resource branch August 7, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants