KymaResourceName and KymaResourceNamespace - KIM integration - phase 1 #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaroslaw-pieszka
added
kind/enhancement
|
Add one of following labels |
kyma-bot
added
the
size/M
jaroslaw-pieszka
force-pushed
the
creating-actual-resource
branch
from
0522f1d
to
a78253f
Compare
piotrmiskiewicz
previously approved these changes
Jul 12, 2024
|
New changes are detected. LGTM label has been removed. |
jaroslaw-pieszka
force-pushed
the
creating-actual-resource
branch
from
0f03b71
to
3555ffb
Compare
logging KymaTemplate length fixture with kymaTemplate
jaroslaw-pieszka
force-pushed
the
creating-actual-resource
branch
from
332fef3
to
f420148
Compare
| channel: stable | ||
| modules: [] | ||
| ` | ||
| preOperation.KymaResourceNamespace = "kyma-system" | ||
| err := memoryStorage.Operations().InsertOperation(preOperation) |
There was a problem hiding this comment.
are you sure that kyma template has proper name/namespace? let's discuss it
There was a problem hiding this comment.
Discussed, needs redesign. Probably in separate PR.
jaroslaw-pieszka
added
the
do-not-merge/hold
|
Redesign required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#905
#791