-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Runtime CR - KIM integration - phase 1 #933
Merged
kyma-bot
merged 4 commits into
kyma-project:main
from
jaroslaw-pieszka:create-resource-and-test-it
Jul 22, 2024
Merged
Create Runtime CR - KIM integration - phase 1 #933
kyma-bot
merged 4 commits into
kyma-project:main
from
jaroslaw-pieszka:create-resource-and-test-it
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add one of following labels |
kyma-bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Jul 12, 2024
jaroslaw-pieszka
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
kind/enhancement
Categorizes issue or PR as related to modifying or improving an existing feature
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
cla: yes
Indicates the PR's author has signed the CLA.
labels
Jul 12, 2024
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
labels
Jul 12, 2024
jaroslaw-pieszka
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jul 15, 2024
jaroslaw-pieszka
force-pushed
the
create-resource-and-test-it
branch
from
July 17, 2024 11:36
b7e2843
to
7b04586
Compare
kyma-bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jul 17, 2024
piotrmiskiewicz
previously approved these changes
Jul 18, 2024
jaroslaw-pieszka
force-pushed
the
create-resource-and-test-it
branch
from
July 18, 2024 12:50
df7b51a
to
312dd3e
Compare
jaroslaw-pieszka
force-pushed
the
create-resource-and-test-it
branch
from
July 18, 2024 12:59
6f9210f
to
7250d10
Compare
piotrmiskiewicz
previously approved these changes
Jul 18, 2024
jaroslaw-pieszka
force-pushed
the
create-resource-and-test-it
branch
from
July 18, 2024 13:08
9253765
to
a2764e8
Compare
piotrmiskiewicz
previously approved these changes
Jul 18, 2024
piotrmiskiewicz
previously approved these changes
Jul 18, 2024
assertion changed test corrected
jaroslaw-pieszka
force-pushed
the
create-resource-and-test-it
branch
from
July 22, 2024 07:15
dd43983
to
059dca6
Compare
szwedm
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla: yes
Indicates the PR's author has signed the CLA.
kind/enhancement
Categorizes issue or PR as related to modifying or improving an existing feature
lgtm
Looks good to me!
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#791
#905