Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Runtime CR - KIM integration - phase 1 #933

Merged

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Jul 12, 2024

Description

Changes proposed in this pull request:

  • Actual object creation if not DryRun
  • Test fixture for HappyFlow test
  • Test happy flow for DryRun
  • Test happy flow for actual creation

Related issue(s)

#791
#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner July 12, 2024 13:16
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Jul 12, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 12, 2024
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 12, 2024
@jaroslaw-pieszka jaroslaw-pieszka added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jul 12, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 12, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 18, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 18, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 18, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 18, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 18, 2024
assertion changed

test corrected
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 22, 2024
@kyma-bot kyma-bot merged commit 284850d into kyma-project:main Jul 22, 2024
22 of 24 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the create-resource-and-test-it branch July 22, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants