Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shoot.Provider content for KIM part 1 #934

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Shoot.Provider content for KIM part 1 #934

merged 9 commits into from
Jul 16, 2024

Conversation

piotrmiskiewicz
Copy link
Member

@piotrmiskiewicz piotrmiskiewicz commented Jul 12, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • part 1 of Shoot.Provider values for KIM in the create_runtime_resource_step

Related issue(s)
Related: #791

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 12, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 12, 2024
@piotrmiskiewicz piotrmiskiewicz changed the title wip Shoot.Provider content for KIM part 1 Jul 12, 2024
@piotrmiskiewicz piotrmiskiewicz marked this pull request as ready for review July 12, 2024 13:27
@piotrmiskiewicz piotrmiskiewicz requested a review from a team as a code owner July 12, 2024 13:27
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 16, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 16, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jul 16, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 16, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 16, 2024
@kyma-bot kyma-bot merged commit 605bb97 into kyma-project:main Jul 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrmiskiewicz @kyma-bot @jaroslaw-pieszka