Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration - add label indicating what drives provisioning #961

Merged
merged 4 commits into from
Jul 30, 2024
Merged

KIM Integration - add label indicating what drives provisioning #961

merged 4 commits into from
Jul 30, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Indicating provisioner in viewOnly mode, KIM otherwise
  • Adding runtimes to RBAC

Related issue(s)

#905
#791

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner July 29, 2024 19:00
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Jul 29, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Jul 29, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 29, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jul 29, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 29, 2024
szwedm
szwedm approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 30, 2024
@kyma-bot kyma-bot merged commit 1059dba into kyma-project:main Jul 30, 2024
31 of 35 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the skipping-preview-fix branch August 7, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @szwedm @kyma-bot