Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIM Integration Check Runtime resource step #982

Merged
merged 3 commits into from
Aug 5, 2024
Merged

KIM Integration Check Runtime resource step #982

merged 3 commits into from
Aug 5, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

@jaroslaw-pieszka jaroslaw-pieszka commented Aug 5, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Step checking if Runtime resource is in the state Ready.

Related issue(s)

#791
#905

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner August 5, 2024 09:16
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Aug 5, 2024
@jaroslaw-pieszka jaroslaw-pieszka added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Aug 5, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Aug 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@jaroslaw-pieszka jaroslaw-pieszka added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed cla: yes Indicates the PR's author has signed the CLA. labels Aug 5, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2024
@jaroslaw-pieszka
initial version
49c4174 
initial version

format change

step on conditions

first test case passing

tests added

less is more

invocation added
@jaroslaw-pieszka jaroslaw-pieszka removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024
piotrmiskiewicz
piotrmiskiewicz previously approved these changes Aug 5, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 5, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 5, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 5, 2024
@kyma-bot kyma-bot merged commit 03aeb0a into kyma-project:main Aug 5, 2024
31 checks passed
@jaroslaw-pieszka jaroslaw-pieszka deleted the check-runtime-resource-step branch August 7, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrmiskiewicz piotrmiskiewicz piotrmiskiewicz approved these changes

Assignees

@piotrmiskiewicz piotrmiskiewicz

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaroslaw-pieszka @piotrmiskiewicz @kyma-bot