Skip to content

Commit

Permalink
Code Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nesmabadr committed Jul 15, 2024
1 parent e8f6fdd commit 8d83d22
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 0 additions & 2 deletions internal/manifest/parse.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ func (p PathExtractor) GetPathFromRawManifest(ctx context.Context,
return manifestPath, nil
}

// pull image layer
layer, err := img.PullLayer(ctx, imageRef, keyChain)
if err != nil {
return "", err
Expand All @@ -65,7 +64,6 @@ func (p PathExtractor) GetPathFromRawManifest(ctx context.Context,
}
defer blobReadCloser.Close()

// create dir for uncompressed manifest
if err := os.MkdirAll(installPath, fs.ModePerm); err != nil {
return "", fmt.Errorf(
"failure while creating installPath directory for layer %s: %w",
Expand Down
3 changes: 1 addition & 2 deletions pkg/img/layer.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ func (o *OCI) String() string {
}

type (
LayerType string
Layer struct {
Layer struct {
LayerName
LayerRepresentation
}
Expand Down

0 comments on commit 8d83d22

Please sign in to comment.