Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Manifest Reconcile Duration Metric #1321

Merged
merged 12 commits into from
Mar 4, 2024
Merged

feat: Add Manifest Reconcile Duration Metric #1321

merged 12 commits into from
Mar 4, 2024

Conversation

LeelaChacha
Copy link
Contributor

Description

Changes proposed in this pull request:

  • added histogram metric reconcile_duration_seconds to KLM with module name as label
  • ...
  • ...

Related issue(s)

Closes #1069

@LeelaChacha LeelaChacha requested a review from a team as a code owner February 17, 2024 16:31
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2024
@LeelaChacha
Copy link
Contributor Author

Note: Due to problems with local setup of plutono dashboard, I was unable to create a new visualization for this metric. It shall be done once this PR merged using DEV landscape's dashboard. The visualization will follow in another PR.

nesmabadr
nesmabadr reviewed Feb 26, 2024
View reviewed changes
pkg/testutils/metrics.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 4, 2024
@kyma-bot kyma-bot merged commit 2b64c7b into kyma-project:main Mar 4, 2024
33 checks passed
LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this pull request Mar 4, 2024
@LeelaChacha
Revert "feat: Add Manifest Reconcile Duration Metric (kyma-project#1321…
5855cd2 
…)"

This reverts commit 2b64c7b.
ruanxin pushed a commit that referenced this pull request Mar 4, 2024
@LeelaChacha
fix: Revert "feat: Add Manifest Reconcile Duration Metric (#1321)" (#…
bc207ab 
…1359)

Revert "feat: Add Manifest Reconcile Duration Metric (#1321)"

This reverts commit 2b64c7b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesmabadr nesmabadr nesmabadr approved these changes

Assignees

@nesmabadr nesmabadr

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce metrics to track each Module Manifest reconcile performance
3 participants
@LeelaChacha @nesmabadr @kyma-bot