Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor ModuleTemplate catalog sync code #2002

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Refactor ModuleTemplate catalog sync code #2002

wants to merge 2 commits into from
+689 −246

Conversation

Tomasz-Smelcerz-SAP
Copy link
Member

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP commented Oct 31, 2024 •
edited
Loading

Description

Refactor ModuleTemplate catalog sync code so that it's testable and the entire CatalogSync can be easily extend to support synchronization for other types.

Changes proposed in this pull request:

  • No change in functionality - just the refactoring
  • Break the coupling between the existing methods by introducing interfaces and factory functions
  • Introduce two new types for catalog sync, ensuring unit testability of the code (for example, abstracting away the K8s clients)
  • Preparing the ground for introducing ModuleReleaseMeta syncing mechanism that can be (almost) copy-pasted from the existing one.

Related issue(s)
#1851

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP requested a review from a team as a code owner October 31, 2024 00:02
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 31, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP changed the title refactor moduletemplate catalog sync code chore: Refactor ModuleTemplate catalog sync code Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tomasz-Smelcerz-SAP @kyma-bot